Comments (5)
Thanks for the observations. Thats another option Kurt, I made the adoption of the delegate not use IBOutlets in case they would not use storyboards.
from cool-ios-camera.
Doesn't really matter if it's a storyboard or a xib. It does no harm, and it makes it codeless if you are using xcode/IB.
from cool-ios-camera.
Also need to implement
- (id)initWithCoder:(NSCoder *)aDecoder {
self = [super initWithCoder:aDecoder];
if (self) {
_animationInProgress = NO;
[self setupCaptureManager:RearFacingCamera];
cameraBeingUsed = RearFacingCamera;
[self composeInterface];
[[_captureManager captureSession] startRunning];
}
return self;
}
(so clearly refactor)
from cool-ios-camera.
Your recommendation for making the id delegate an IBOutlet is a great idea, however given the use this lib will probably get I believe its better to leave as it is for clarity's sake for new developers.
I already pushed the initWithCoder function, thank you very much!
from cool-ios-camera.
I agree, the code base is cleaner and easier to use this way! Thanks GabrielAlva
from cool-ios-camera.
Related Issues (20)
- Capture to square HOT 1
- Open Camera on Start Up HOT 4
- Capture to 4:3 HOT 1
- missing lib dependency in Installation instruction HOT 1
- Launch in tab navigation view HOT 2
- Make more than one photo HOT 1
- Launch screens may not use instances of IBUIStoryboardEntryPointIndicator.? HOT 2
- Spelling Corrections (toogle to toggle, loose to lose, thats to that) HOT 1
- Mach Linking Error with arm64 in Xcode 7 iOS 9 and swift 2.0 HOT 1
- Need help to turnoff default flash
- How to add an overlay to camera view HOT 2
- Zoom functionality
- Customization api do not work
- Any chance of bringing this to Swift? HOT 2
- Please add podspec
- I am using this project in my app (swift) HOT 1
- Crash report when I take pictures several times.
- iOS 10+ support HOT 1
- Camera is Little bit zoomed
- Deprecation in iOS 10+
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cool-ios-camera.