Giter Club home page Giter Club logo

Comments (5)

GabrielAlva avatar GabrielAlva commented on September 26, 2024

Thanks for the observations. Thats another option Kurt, I made the adoption of the delegate not use IBOutlets in case they would not use storyboards.

from cool-ios-camera.

kwerle avatar kwerle commented on September 26, 2024

Doesn't really matter if it's a storyboard or a xib. It does no harm, and it makes it codeless if you are using xcode/IB.

from cool-ios-camera.

kwerle avatar kwerle commented on September 26, 2024

Also need to implement

- (id)initWithCoder:(NSCoder *)aDecoder {
    self = [super initWithCoder:aDecoder];
    if (self) {
        _animationInProgress = NO;
        [self setupCaptureManager:RearFacingCamera];
        cameraBeingUsed = RearFacingCamera;
        [self composeInterface];

        [[_captureManager captureSession] startRunning];
    }
    return self;
}

(so clearly refactor)

from cool-ios-camera.

GabrielAlva avatar GabrielAlva commented on September 26, 2024

Your recommendation for making the id delegate an IBOutlet is a great idea, however given the use this lib will probably get I believe its better to leave as it is for clarity's sake for new developers.

I already pushed the initWithCoder function, thank you very much!

from cool-ios-camera.

Knights22 avatar Knights22 commented on September 26, 2024

I agree, the code base is cleaner and easier to use this way! Thanks GabrielAlva

from cool-ios-camera.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.