Giter Club home page Giter Club logo

Comments (3)

lh3 avatar lh3 commented on August 14, 2024

It is common for the same sequence to have different accessions in different sub-databases from NCBI, but in one database, such as RefSeq, there is no redundancy, I think. That said, I am supportive of having multiple sourceAccessions associated with one GAReference.

from ga4gh-schemas.

calbach avatar calbach commented on August 14, 2024

OK, so the remaining issue is around the relationship of GAReferenceSet::sourceAccession and GAReference::sourceAccession. I don't think I understand the current semantics, as I thought that an assembly (ReferenceSet) had one accession number, while the individual contigs in the assembly (References) had entirely different accession numbers.

To give a concrete example:
GRCh38 as the assembly has accession GCF_000001405.26 in RefSeq. I would expect this to be the value of GAReferenceSet::sourceAccession.
chr1 of GRCh38 has an accession of NC_000001.11 in RefSeq. I would expect this to be the value of GAReference::sourceAccession.

Am I misunderstanding something? If not, I don't understand the semantics on GAReference::sourceAccession:

The accession from which the sequence was obtained, if not given in the
containing GAReferenceSet.
In INSDC (GenBank/ENA/DDBJ) with a version number. (e.g. GCF_000001405.26)

from ga4gh-schemas.

pgrosu avatar pgrosu commented on August 14, 2024

@calbach, you are right, less is more by having one assembly identified in GAReferenceSet::sourceAccession, but the key here is that with GAReferenceSet you specify multiple GAReference via array<string> referenceIds = [];. If you have multiple GAReference, and you want sourceAccession granularity for specific GAReference that customize your GAReferenceSet, you can overide it with GAReference::sourceAccession as the comment mentions: "Can be overriden by the sourceAccession field in a specific GAReference". This way you have flexibility in how you build your GAReferenceSet.

from ga4gh-schemas.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.