Giter Club home page Giter Club logo

Comments (3)

g00fy- avatar g00fy- commented on July 27, 2024

This is a css selector issue. provided css and templates are only to provide examples.
One solution may be to use [*date-picker] pattern as a selector.
See http://www.w3.org/TR/css3-selectors/#selectors

from angular-datepicker.

astik avatar astik commented on July 27, 2024

That was a simple one and I didn't think of it … my bad.
Anyway, it would be better to have a CSS class.
Depending on the attribute to apply style is not the best solution : [*date-picker] may not be a fast selector.
Do we really need to know that it's a date-range ? Wouldn't the .date-picker class be enough (it is applied on each date-picker) ?
In that case, instead of :

[date-range] [date-picker] .after.before

We could write :

.date-picker .after.before

from angular-datepicker.

g00fy- avatar g00fy- commented on July 27, 2024

As I said, the bundled templates are only to provide some examples. You should not use them in your production version, as ie. the default date-picker template is very slow (because evaluating the expression used in ng-class is very slow).

I think the appropriate solution here would be having some fixed classes (like ng-dirty ng-model ng-pristine) and so we don't have to use ng-class), but currently I can't find any reasonable naming convention.

from angular-datepicker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.