Allow LogicalColumnReader to be IEnumerable<T> about parquetsharp HOT 4 CLOSED

I'd favour a method that returns an IEnumerable from a LogicalColumnReader rather than making the reader IEnumerable.

from parquetsharp.

foreach (var value in rowGroupReader.Column(c).LogicalReader().Enumerate())
{
    /* ... */
}

from parquetsharp.

I'd probably name that AsEnumerable() as opposed to Enumerate() to be more idiomatic.

But TBH I'm not sure why you'd bother returning a separate IEnumerable<T> like that, instead of just making LogicalColumnReader implement it. What's the reasoning there? You're already going to need to make an IEnumerator<T> which does the right thing, so why would you favour adding another layer?

from parquetsharp.

This should be fixed in 1.4.0.2-beta3. @herebebeasties argument swayed me in favour of implementing IEnumerable<T> directly.

from parquetsharp.