make check failing on NixOS about fwup HOT 13 CLOSED

Fixed! The difference was indeed related to glibc 2.26. The implementation of open() was changed to call the openat syscall. I didn't handle the openat syscall in the syscall validator, so it was throwing an error. It's handled now. Thanks for reporting this. I'll make a patch release shortly.

from fwup.

Thanks for letting me know about this. That really looks like an issue with the test suite rather than fwup itself. Between the versions that you referenced, I added code to validate syscalls since there are non-obvious constraints with buffer alignment, sizes and offsets on some platforms. That code is failing, but it's failing since the syscalls aren't being captured. I doubt that anything here is a problem for NixOS, but something could be hiding.

I'm not a NixOS user so I tried pulling down the NixOS appliance and installing everything needed to build fwup (like gcc, autoconf, automake, libconfuse, libarchive, etc.). I'm stuck at what looks like a noob issue, but my searches are failing me. gcc fails to build anything with error trying to exec 'as': execp: No such file or directory. I didn't see a build-essential package for NixOS. Any ideas how I may reproduce and debug?

from fwup.

@fhunleth Thank you for your effort! You can run nix-shell '<nixpkgs>' -A fwup to enter the build environment with all the dependencies for fwup.

from fwup.

I just ran the following in a fwup source directory:

nix-shell '<nixpkgs>' -A fwup
./autogen.sh
./configure
make
make check

All tests passed for me.

I'm running NixOS 17.09.2249.6b8833df272 (x86_64-linux) in VirtualBox. Are you running something different?

from fwup.

Sorry about that, NixOS 17.09 contains the old version of fwup. Could you run nix-channel --add https://nixos.org/channels/nixpkgs-unstable and nix-channel --update before entering the shell.

from fwup.

I checked out fwup v0.18.0 from Github to ~/fwup and built it there. I ran the commands that you wrote and re-entered the shell. Should I be compiling from a different directory?

from fwup.

My bad, that should be fine. Then it looks like a problem with environment. Could you try using nix-shell '<nixpkgs>' -A fwup --pure to sandbox the shell?

from fwup.

Ok, --pure is really cool.

I ran make distclean first to start a fresh build and then repeated what I did above. I have the same result. I.e. everything works.

from fwup.

Sorry, we have not checked if the tests of the newer fwup fail in NixOS 17.09 (EDIT: they don't), only in the NixOS master (aka unstable). One of the differences is the upgrade to Glibc 2.26.

from fwup.

Could you unpack https://github.com/NixOS/nixpkgs/archive/master.tar.gz somewhere and run nix-shell path/to/master -A fwup --pure? This should reproduce test failure. (EDIT: doing what @jtojnar has said about nix-channel is equivalent to the manual downloading and unpacking.)

from fwup.

Downloaded and unpacked and I'm finally getting the failures! Investigating...

from fwup.

Thank you for the fix (and for introducing me to the open_by_handle_at syscall)!

from fwup.

Thanks @jtojnar and @orivej again for reporting the issue and helping me reproduce it. The 0.18.1 release is now available with the fix.

from fwup.