Giter Club home page Giter Club logo

Comments (1)

fhunleth avatar fhunleth commented on June 27, 2024

Fwup can't warn on unset variables, or at least I'm pretty sure that it can't, since the variable lookup is done by libconfuse. Fwup can detect empty strings for parameters, though, and I think that will catch what happened to you. I thought that I handled this case, but it turned out that if you had a variable as a parameter and it was undefined that an empty string was passed. strtoull happily returned 0 instead of reporting an error. I added a check to fail on empty strings. The error message is not as helpful as it could be, but you'll get an invalid argument error with the right line number. That should be a big improvement over succeeding and accidentally overwriting your MBR or whatever is at offset 0.

The fix is in 485befd.

from fwup.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.