Comments (9)
Thanks! I can't believe that I hadn't noticed that when I first added man page generation, but it's definitely there. Fix coming shortly...
from fwup.
Okay, seems like you beat me in fixing this ;)
from fwup.
Oops - I should have waited. The bug was a little embarrassing, though, so I wanted to be done with it. I appreciate you taking the time to let me know and for putting together the patch.
from fwup.
Nah, it's all fine. From a quick glance your patch seems to be more elegant than mine. My C is quite rusty anyway.
Am I right that your patch returns failure when invoking --help? Shouldn't that rather be success because when fwup --help
prints the help message it successfully did what the user requested?
Oh and out of curiosity, why not using the -h
short option but -?
?
from fwup.
You're right - mine does return error when specifying --help
and that's not right. As for -h
vs -?
, my fingers type -?
frequently, but -h
makes sense too. Would you mind resubmitting your patch with the one simplification of handling the call to print_usage in the switch rather than making a full-fledged command out of it? You really should get full honors for this.
from fwup.
Here we go. I kept -h
as short option but would not mind to change that to -?
if you prefer that.
from fwup.
Looks good to me. I merged it. Thanks again!
from fwup.
D'uh... one minor styling issue with my patch... line 331 is not correctly aligned.
from fwup.
No worries - I'll fix it.
from fwup.
Related Issues (20)
- fsck.fat v4.2 failure HOT 4
- question: sometimes, for ext4 partition, no sparse compression is done HOT 4
- Failed to start File System Check on Root Device HOT 6
- fwup:amd64 : Depends: libc6:amd64 (>= 2.4) but it is not installable HOT 8
- Add `.deb` for `aarch64` to the releases
- zlib-1.2.11 is no longer available from zlib.net HOT 3
- Add lock file support
- Support usb drive or card reader HOT 4
- Compiling with glibc 2.36 fails due to conflicting headers HOT 1
- xdelta tries to read too much data HOT 5
- Handle /dev/null as a special case output device HOT 4
- Support delta-source-fat-offset and delta-source-fat-path HOT 4
- Arm build is missing from releases. HOT 1
- u-boot redundant environment support issue HOT 5
- UMS is not detected by fwup on Windows 11 HOT 5
- fwupd defeated by secure boot kernel lockdown? HOT 1
- Test failure installing 1.10.1 HOT 3
- Suggestion: Ignore tiny discovered drives/devices HOT 4
- Signing firmware files post-delta creation fails
- Red Hat support HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fwup.