Giter Club home page Giter Club logo

Comments (6)

fwenzel avatar fwenzel commented on August 25, 2024

I am not opposed to it and it's certainly an easy feature to add. Not sure why it's necessary but a checkbox in the settings is easy.

Popup time I don't think would work.

from copy-shorturl.

mcepl avatar mcepl commented on August 25, 2024

Wouldn't it be better to change this into page-action so that the button does not occupy valuable real estate in the toolbar? Then you wouldn't have to make it optional.

from copy-shorturl.

fwenzel avatar fwenzel commented on August 25, 2024

What does that have to do with the notifications?

from copy-shorturl.

fwenzel avatar fwenzel commented on August 25, 2024

And every webextension shows up in the toolbar. That's not my decision. You can right click and remove / put it into the hamburger menu.

from copy-shorturl.

mcepl avatar mcepl commented on August 25, 2024

a) Oh, sorry, I have misunderstood what's this issue is about. b) now, they are not. Only the ones with browser-action in manifest.json do. See https://github.com/mdn/webextensions-examples/tree/master/apply-css for an example of the extension which won't get a button in the toolbar.

from copy-shorturl.

fwenzel avatar fwenzel commented on August 25, 2024

Ah thank you for explaining this to me! I think it's fine for this extension to have a button though. People can remove the button if they don't want it.

from copy-shorturl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.