Giter Club home page Giter Club logo

Comments (9)

FWeinb avatar FWeinb commented on July 4, 2024

That sounds very strange. Is your application exited gracefully or crashing?

from electron-screenshot-service.

asafyish avatar asafyish commented on July 4, 2024

We are using pm2 (https://github.com/Unitech/pm2) and doing pm2 restart. I am not exactly sure how it kill the process.

from electron-screenshot-service.

FWeinb avatar FWeinb commented on July 4, 2024

It looks like pm2 is sending a SIGINT to the process. So you might want to add the screenshot.close() call like this:

process.on('SIGINT', function() {
  screenshot.close();
});

from electron-screenshot-service.

asafyish avatar asafyish commented on July 4, 2024

Tried that... no luck. we still have hundreds of process.
BTW, we are using scale to 20. Is that related ?

from electron-screenshot-service.

FWeinb avatar FWeinb commented on July 4, 2024

Scale 20 should just scale the amount to 20 processes (so approx. 20 electron + 20 electron helpers) But there could be more than 1 helper per site.

from electron-screenshot-service.

asafyish avatar asafyish commented on July 4, 2024

Maybe using something like https://npmjs.org/package/child-killer when spawning the process could help ?

from electron-screenshot-service.

FWeinb avatar FWeinb commented on July 4, 2024

This sounds really strange. Is the callback called by pm2? child-killer is polling every 100ms for each process, I would rather not do that. Which OS are you using?

from electron-screenshot-service.

asafyish avatar asafyish commented on July 4, 2024

We are using Ubuntu 15.04.
What solved the problem is listening fro SIGTERM:

process.on('SIGTERM', function () {
        screenshot.close();

        setTimeout(function() {
            process.exit(0);
        }, 1000)
    });

from electron-screenshot-service.

FWeinb avatar FWeinb commented on July 4, 2024

Glad you found a solution.

from electron-screenshot-service.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.