After the recent upgrade to v4.2.0 events are not rendered anymore. about fullcalendar-vue HOT 25 CLOSED

4.2 seems broken. Resources are not shown anymore, even if I use props instead of an event (or no renderer at all). It's also undocumented. I'd guess we have to wait a little bit longer :)

from fullcalendar-vue.

@techouse whatever you had previous in regards to datesRender/eventRender/viewSkeletonRender should continue to work fine. eventually, I'll want you to write:

<FullCalendar :datesRender="myDatesRenderFunc" />

@doncatnip, what's undocumented?

from fullcalendar-vue.

I'm glad everything is seems to be fixed.

I needed to publish another patch release 4.2.2 because I noticed another bug related to event objects with Date objects. Please upgrade to 4.2.2.

Closing this issue. Please open a new ticket if you experience continued problems.

from fullcalendar-vue.

@ColdIce1, thanks for the recreation. I now see the problem. It's a bug with accepting functions for events/resources. The new algorithm relies on recursively copying some of the props, and that doesn't work for functions. As soon as I'm confident there's no other causes for this bug and related bugs, I'll get to work on a fix.

@jameshood118, it looks like you're hoping the JSON at https://jsonplaceholder.typicode.com/todos/1 would render events, but it's not a valid array of valid event objects, so it won't render anyway.

from fullcalendar-vue.

@doncatnip @arshaw That's exactly the problem. For testing I passed an empty array to the resources prop and called a window.setTimeout to fill that array with resources. But the changes do not take effect and the resources never appear.

from fullcalendar-vue.

Can confirm, but its not just an upgrade issue, my team switched over to this from a different component, which was a wrapper for fullcalendar). I can get events to render when i manually set an array of objects on vue data, however, our data comes from a graphql query, data is being passed into the component, but is not displaying the events

from fullcalendar-vue.

I will fix this ASAP, but I need a reduced test case.

Here are some 4.2.0 debug templates I made

• month view: https://codesandbox.io/s/8xyz32l0r8
• timeline view with resources: https://codesandbox.io/s/fullcalendar-vue-w-resources-oqzcg

Both of these examples seem to work fine with 4.2.0

I need more info from you before i can fix

from fullcalendar-vue.

I just released 4.2.1. I believe I fixed everything. Thanks for the bug reports.

Could you all PLEASE CONFIRM this release fixes your issues?

from fullcalendar-vue.

When i take my returned data set, from my graphql query, and set it on data, it renders, but using vue-apollo to hit my graphql endpoint to return data doesnt seem to render. Maybe trying consuming a rest end point?

https://jsonplaceholder.typicode.com/posts

Its certainly not exactly the same things fullcalendar expects to see, but something should display

The following works to display an event but pulling the same exact data from graphql doesnt, even though the event is being returned by the endpoint and passed into the component.
export default { name: 'Calendar' data() { return { events: [ { id: 'cjwgi3cpa0a640802zintzajn', title: 'Test Inject', description: '', type: 'Key', method: 'Email', number: 17, owner: '', trigger: '', response: '', remarks: '', attachments: [], deletedAt: null, start: '2019-06-03T11:00:00.000Z', end: '2019-06-03T11:00:00.000Z', from: '', to: '', participants: [], objectives: [], color: '#219A54' } ], } } }

from fullcalendar-vue.

@jameshood118 , the problem is probably not dependent on graphql. Its seems like a bug related to asynchronously setting the events after initialization. Any way you can simulate that in a recreation? Just set the events to a static array?

from fullcalendar-vue.

@jameshood118 , the problem is probably not dependent on graphql. Its seems like a bug related to asynchronously setting the events after initialization. Any way you can simulate that in a recreation? Just set the events to a static array?

See above, i hit post too soon.

from fullcalendar-vue.

Vue Dev tools, showing the event is being passed into the component, past that, i've no clue, maybe im missing something

from fullcalendar-vue.

@jameshood118 that helps a little, but I really need a reduced test case to proceed.

from fullcalendar-vue.

Here is a test case: https://codesandbox.io/s/fullcalendar-vue-w-resources-tv064
on using resources that does not render. This works on 4.1.0

from fullcalendar-vue.

Maybe not the best example, but:

https://codesandbox.io/s/fullcalendar-vue-e02ox

using the jsonplaceholder i previously mentioned, this console logs the return, but its also using it in the calendar (which doesnt render)

from fullcalendar-vue.

You are right, I missed that part, my apologies

from fullcalendar-vue.

I can also confirm that this bug seems to also affect the resources. In my application i'm loading resources and events via AJAX, but no event nor resource get's rendered in 4.2.0.

from fullcalendar-vue.

@chrisribal can you post a recreation based on this?
https://codesandbox.io/s/fullcalendar-vue-w-resources-oqzcg

i need to see if you're using a function as your resources setting or not. or maybe something else is going on

from fullcalendar-vue.

@doncatnip, what's undocumented?

Ho to use that props exactly. I guess it is on the fullcalendar docs itself, but not here in the vue wrapper nor the vue wrapper example. The tag message doesn't say anything about an api change either. (Edit) Correction: past tense. It did not say anything about an api change.

from fullcalendar-vue.

The problem seems to be with computed resources: if first an empty Array is returned, then any subsequent arrays filled with actual resources will not be shown:
https://codesandbox.io/s/fullcalendar-vue-w-resources-gn84y

Edit: Only the initial array is relevant. Subsequent updates to a computed property will be ignored. This should not be the desired behaviour. Might need to check if this is the same for events.

from fullcalendar-vue.

Pulling and testing now

from fullcalendar-vue.

YAY i have events on my calendar, you're the man @arshaw .. Well you and your team, obviously

from fullcalendar-vue.

@arshaw Seemed to fix all the issues that popped up for me in 4.2.0

from fullcalendar-vue.

All fixed for me as well. Thanx ❤️

from fullcalendar-vue.

I seem to get this issue when I load from a json URL, I have tried various different things to fix this. I have run it as an identical copy of the example. I start with calendarEvents: [] and then populate that from an axios get request where I quite simply do this.calendarEvents = data when I use dev tools I can see the Array of objects with my events properly filled out, but they do not render on the calendar, I have tried using the feed in eventResources too but to no avail, the call is made successfully but the events are not populated. I will be back in abit and will post this as a reduced-test-case but wondered if anyone had any ideas in the meantime as this is impacting a fairly significant deploy.
Thanks in advance

from fullcalendar-vue.