Giter Club home page Giter Club logo

Comments (2)

malclocke avatar malclocke commented on August 16, 2024

Hi Steven,

Yes, the highlight hasn't been working for some time. I'm afraid I can't remember if it was broken by some change or whether I turned it off intentionally. I vaguely remember there might have been a problem with the callback order that triggers it.

Has been a low priority to fix, but would be awesome to get it going again. Let us know if you have any questions.

from fulcrum.

corroded avatar corroded commented on August 16, 2024

We're still investigating but based on our observations, it seems that the story does highlight BUT we don't see it because it is being deleted and created at the same time. This is what we think is happening(correct me if I'm wrong):

  1. Story is updated(we usually test this with FF and Chrome - we update the story estimate in FF then wait in Chrome for it to update)
    2a. Since story was updated, the page re-renders everything(project_view has a binding for all changes to stories).
    2b. When the browser polls and sees the changeset, it runs the highlight script.

These both happen almost at the same time and in effect, the re-render "covers" the intended highlight. If this sounds a bit confusing, try these steps to see it in action:

  1. Open a project w/ FF and Chrome.
  2. In Chrome, inspect a story and get its id then open console and select it using jQuery.
    $("#1149")
  3. Run the effect manually on it through console. Based on our investigations, the most effective effect to use for understanding is explode(any other effect won't be seen because of the bug)
    $("#1149").effect("explode", {}, 3000);
    You should see the story explode, fade out and disappear from the story list.
  4. Refresh Chrome. Now go to FF, change the estimate of that story then switch back to Chrome and wait for the change to re-render the page.

You'll see the explode effect, but the story stays there, meaning there's another story being created on top of it.

We're still working on a fix(probably just some timing issue?) but if you have any suggestion as to which path to take or any insight as to which files/lines to look out for, it would be great.

from fulcrum.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.