Giter Club home page Giter Club logo

Comments (5)

billykan avatar billykan commented on June 22, 2024 1

I have tried to compile libqrencode on arm64 and got two compilation warnings "Implicit conversion loses integer precision 'unsigned long' to int". They are from qrencode.c under the functions QRcode_encodeString8bit and QRcode_encodeString8bitStructured. In both cases, the problematic code is:

ret = QRinput_append(input, QR_MODE_8, strlen(string), (unsigned char *)string);

The problem is strlen() is returning "unsigned long" under arm64 and QRinput_append accepts "int" instead, causing a truncation of value.

Hope it helps.

from libqrencode.

fukuchi avatar fukuchi commented on June 22, 2024

While I want to support arm64 platform, I have no machines to test it. I'd like to ask you to test the latest libqrencode on arm64 and let us know if you found any issues.

from libqrencode.

billykan avatar billykan commented on June 22, 2024

The other issues are in split.c where there were many pointer arithmetics and the results are stored in int - again truncation would occur when as pointers are changed to 8 bytes in arm64

from libqrencode.

ArtSabintsev avatar ArtSabintsev commented on June 22, 2024

@billykan if you know ahead of time that you're dealign with small values, you can silence that warning by typecasting to uint32_t:

ret = QRinput_append(input, QR_MODE_8, (uint32_t)strlen(string), (unsigned char *)string);

I feel your pain though.

from libqrencode.

fukuchi avatar fukuchi commented on June 22, 2024

Thank you @billykan and @ArtSabintsev for your reports. I'll fix this issue in the development branch.

from libqrencode.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.