Comments (3)
@digorithm @iqdecay Do we still want this?
The effort needed to achieve this is non-neglectable, but protecting against regressions would be even harder.
If the abigen-ed code ever stops being generated by a macro, then it is up to the owners to format them in whatever way they wish. We cannot predict their rustfmt config.
from fuels-rs.
You're right that this is kind of "too hard". I think since your PR we are generating actual code instead of strings, you can close?
from fuels-rs.
This is actually not a good-first-issue
. One example:
impl #enum_ident {
pub fn param_types() -> Vec<ParamType> {
let mut types = Vec::new();
#( #param_types; )*
types
}
Here, the macro will always add an extra ,
to the end of the declared enum variants, but rustfmt
doesn't. It's too "hard" and annoying to fix this for mere esthetic purposes.
Putting as low-priority.
from fuels-rs.
Related Issues (20)
- Check if `Abigen` is re-exported to fuels reexports (maybe add doc section why we want to do this)
- Make sure all `Future`s are `Send`able
- Investigate if ABI encoder/decoder can accept something that can be turned into an iterator instead of slice
- Revert OutOfGas error when using the produce_blocks function in the provider to go forward in time HOT 4
- Error out on excess bytes in the decoder
- `LogFormatter` should not be public HOT 1
- Investigate if we can remove the `AsciiString` type
- Add option to not derive `tokenizable` and `parameterizable` and split `tokenizable` into two parts (encoding and decoding)
- Check if debug with depth can make a prettier debug output
- User-overwriteable type mappings during the abigen
- Investigate if we can the estimation performed right before the transaction is sent
- Investigate the possibility of using the type state pattern on the contract instance struct
- Delete response method from call handler
- Mention estimation caveat in docs
- Cannot connect to fuel core server HOT 2
- Enable provider connection to testnet test
- gas price variation impacts set max fee
- max fee tolerance is not reflected when covering with base asset
- Memory-write-overlap bug
- Blob tx support HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fuels-rs.