Giter Club home page Giter Club logo

Comments (3)

segfault-magnet avatar segfault-magnet commented on July 24, 2024 1

@digorithm @iqdecay Do we still want this?

The effort needed to achieve this is non-neglectable, but protecting against regressions would be even harder.

If the abigen-ed code ever stops being generated by a macro, then it is up to the owners to format them in whatever way they wish. We cannot predict their rustfmt config.

from fuels-rs.

iqdecay avatar iqdecay commented on July 24, 2024 1

You're right that this is kind of "too hard". I think since your PR we are generating actual code instead of strings, you can close?

from fuels-rs.

iqdecay avatar iqdecay commented on July 24, 2024

This is actually not a good-first-issue. One example:

impl #enum_ident {
    pub fn param_types() -> Vec<ParamType> {
        let mut types = Vec::new();
        #( #param_types; )*
        types
    }

Here, the macro will always add an extra , to the end of the declared enum variants, but rustfmt doesn't. It's too "hard" and annoying to fix this for mere esthetic purposes.
Putting as low-priority.

from fuels-rs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.