Giter Club home page Giter Club logo

Comments (1)

adlerjohn avatar adlerjohn commented on June 6, 2024

Uniquely identifying deposits is defined here https://github.com/FuelLabs/fuel-specs/blob/afcb701935f975a327353bd4721f7e0218807ae8/specs/protocol/identifiers.md#utxo-id (pending actually having a deposit format, which we can defer until the smart contract implementation begins), as of #95 merged yesterday.

keeping them the same as before unless further changes are required

I disagree. There's no benefit to restricting ourselves to anything in the v1.x design, which was made ad-hoc without fully planning things out. The smart contracts will be re-written and changing the deposit format is trivial in a properly-abstracted codebase.

I would keep the same properties for deposit, namely the block number, amount, token and receiver.

This doesn't match up with the documented deposit ID (https://github.com/FuelLabs/docs/blob/e2d57505997a9a8af0438d57191df2ab024af04d/src/v1.0.0/3.%20Concepts/1.%20Data%20Structures/Deposits.md#deposit):

Deposits are uniquely keyed by { owner, token, blockNumber }

from fuel-specs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.