Giter Club home page Giter Club logo

Comments (13)

forki avatar forki commented on August 10, 2024

can you please send a pull request?

from fsharpx.extras.

rojepp avatar rojepp commented on August 10, 2024

Is there a reason why XamlTypeProvider is not using System.Windows.Markup.XamlReader instead of XmlReader?
XamlReader has already solved the issue of resolving Xaml Node names to the correct types, no need to do it again?

from fsharpx.extras.

rojepp avatar rojepp commented on August 10, 2024

@nrolland As I understand the code (haven't verified yet), you can have members in the generated type outside of System.Windows.Controls, but they will be of type Object. Xaml documents do list their dependencies, so we can do a better job here.
If I get some free time I'll look into it.

from fsharpx.extras.

rojepp avatar rojepp commented on August 10, 2024

Argh, I wanted my pull req to be part of this issue instead of creating a new one, #160. I'm not used to GH.

from fsharpx.extras.

nrolland avatar nrolland commented on August 10, 2024

Do you have a doc mentioning this resolution of Xaml nodes to the correct types? This is interesting.

from fsharpx.extras.

nrolland avatar nrolland commented on August 10, 2024

Ok I see what you mean, i was out of it, Yeah so the types will be resolved, but the assembly referenced that contain those types might not be loaded I guess. (Not sure I remember everything) So that is why you say it will be of type object, which kind of spoils the typeprovider fun

from fsharpx.extras.

rojepp avatar rojepp commented on August 10, 2024

My commit fixes this for external controls, i.e. controls not defined in the current assembly.
If you create a custom control inside the same assembly that is being 'TypeProvided' it is always going to be of type object, simply because the type doesn't exist yet, so we can't resolve it. :)

from fsharpx.extras.

nrolland avatar nrolland commented on August 10, 2024

Got it. Ahh.... Multistage execution + a proper composable dependency
model... Life would be good...

On Tuesday, November 27, 2012, Robert Jeppesen wrote:

My commit fixes this for external controls, i.e. controls not defined in
the current assembly.
If you create a custom control inside the same assembly that is being
'TypeProvided' it is always going to be of type object, simply because the
type doesn't exist yet, so we can't resolve it. :)


Reply to this email directly or view it on GitHubhttps://github.com//issues/87#issuecomment-10738457.

Nicolas Rolland
mobile : +33 6 62 88 42 92

from fsharpx.extras.

nrolland avatar nrolland commented on August 10, 2024

This is a brilliant change..

from fsharpx.extras.

rojepp avatar rojepp commented on August 10, 2024

Thanks! :)

from fsharpx.extras.

forki avatar forki commented on August 10, 2024

Can I close this?

from fsharpx.extras.

rojepp avatar rojepp commented on August 10, 2024

Works for me, but @nrolland should weigh in.

from fsharpx.extras.

nrolland avatar nrolland commented on August 10, 2024

sure ! thank you robert. it gives me a pretext to look into the specifics of the xamlreader!

from fsharpx.extras.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.