Code style guidance for new structure about fsharpx.collections HOT 5 OPEN

Hi Humza, checking.

from fsharpx.collections.

Hi Grzegorz.

Thanks for your time and help. Sure, I'll create a PR tomorrow hopefully (almost 10 PM here).

I appreciate your help and don't worry about response times. I think you were right about the Expecto error being a local issue as it isn't happening anymore.

Appreiate your help. Thanks again.

from fsharpx.collections.

I've got all the tests passing in my repository (isEmpty, exists, notExists, tryFind, find, toList/Array/Seq, ofList/Array/Seq, fold/foldback, insert, delete) so this is all I'm waiting for before adding the structure here via a pull request.

There is one error using find in the below code:

test "test find" {
            let tree = AaTree.ofList ["hello"; "bye"]
            Expect.equal "hello" <| AaTree.find "hello" tree <| ""
            // Expecto doesn't catch this expected exception for some reason.
            // Expect.throws (fun () -> AaTree.find "goodbye" tree |> ignore) ""
        }

It throws an error as expected, but that error propagates to Expecto's test (Visual Studio breaks the program because of an uncaught error), so the behaviour works but there is one problem with the test code which I am not sure how to handle.

Appreciate your help with the test and/or the code style question.

Link to my repository (not a fork of this) if curious: https://github.com/hummy123/Functional-AA-Tree .

Thanks,
Humza

from fsharpx.collections.

Apologies for having put work on your plate over the weekend. 😅 No rush, but I appreciate it whenever you get there.

Edit: I made a new and final commit (everything else is fine from what I see) swapping the names of the fold and foldback functions because I had named them the wrong way around. However, everything is fine now from what I see.

from fsharpx.collections.

Hi Humza,
I took a look at your code and it looks promising! Please create a PR for adding AATree to this repo.

After you create it we can work out the details. For starters let's go with the rec namespace. It can always be replaced with something more elegant later. To be transparent - I'm willing to deep check your PR, provide suggestions, work on the kinks and check you implementation with the linked paper, but I can't promise quick response times on my side.

For the unexpected Expecto exception behavior pls check https://github.com/hummy123/Functional-AA-Tree/pull/1 . I suspect that this was something going wrong on your machine as it works as expected in CI and on my machine.

from fsharpx.collections.