Auto format when finishing block about fantomas HOT 7 CLOSED

It seems like a nice-to-have feature.

In VS's C# formatting, does this have the same key combination as formatting selection?

We can do matching braces to capture a selection and feed in formatting selection. It seems that we can find a well-form expression from these delimiters.

More work has to be spent on setting correct caret and scrollbar positions in VS extension.

from fantomas.

there's not key combination for this. when you type a ; or a } and the previous block was not propertly formatted, it does that for you straight away. Sometimes I delete and retype a } on purpose so just that the formatting kicks in as it's more pratical than selecting the whole block and pressing Ctrl+K F

from fantomas.

It's almost like formatting-as-you-type. In the long term, it would be nice to be able to do so.

Some immediate hinders are:

• Performance: Fantomas does both lexing and parsing whenever formatting a block. Some caching is needed to avoid lexing and parsing the same block again and again.
• UI interaction: My skills on VS extension and C# are quite limited, so it will take a lot of time to write UI interaction part.

In the mean time, we can implement "formatting a block around the caret". From the caret's position, we find first block of }, ] and ) and format them. We can reuse formatting selection and UI interaction is quite simple. I notice VS' C# formatting does this while Fantomas displays an error on empty selection.

What do you think?

from fantomas.

Yes, for starters having the Ctrl+K F work without a selection and finding the nearest block to the caret position would already be good. @jaredpar maybe you can help on this?

from fantomas.

It seems like you just want to trigger off certain keys being typed into the editor. If that is the case then you just need to look for those keys to be typed inside of StandardCommandDispatcher::Exec. Key strokes are expressed as TYPECHAR commands and they will go through every IOleCommandTarget::Exec implementation. You can just look for one of those to go by and decide to format based on the character and context in which it is typed. This is exactly how C# and the like do their auto-formatting.

from fantomas.

@jaredpar Is there any particular place in VsVim to gain understanding about this?

from fantomas.

Take a look at the following files

https://github.com/jaredpar/VsVim/blob/master/Src/VsVimShared/VsCommandTarget.cs
https://github.com/jaredpar/VsVim/blob/master/Src/VsVimShared/OleCommandUtil.cs
https://github.com/jaredpar/VsVim/blob/master/Src/VsVimShared/OleCommandData.cs

They are the core of the IOleCommandTarget handling logic.

from fantomas.