Giter Club home page Giter Club logo

Comments (3)

nrolland avatar nrolland commented on May 30, 2024

That is not the issue I am facing. the behaviour wr to user input is sanitized and seems consistent : no trailing
I need to dig further why it does not scan...

from fake.

nrolland avatar nrolland commented on May 30, 2024

ok I found the source of the pb : in the code below, test1 and test4 do not work :
when you END your base directory with a (not (platform-dependant slash) then it does not work.

This is because we sanitize user input by removing the trailing slash platform-dependant slash, while we allow otherwise non platform dependant directory separators in cleanpath

/// Patterns can use either / \ as a directory separator.
/// cleanPath replaces both of these characters with Path.DirectorySeparatorChar
let cleanPath path = (cleanPathBuilder path).ToString()


[] //fails
let test1 () =
let basedir = SOURCE_DIRECTORY + @"\dirfortesting/"
let csvfiles = Include(@"/*.csv" ) |> SetBaseDir basedir |> Fake.FileSetHelper.ScanImmediately
|> Seq.map Path.GetFileName
|> Set.ofSeq
let set = ["file1 - Copy.csv" ; "file1.csv" ] |> Set.ofSeq
test <@ csvfiles = set @>

[]
let test2 () =
let basedir = SOURCE_DIRECTORY + @"\dirfortesting"
let csvfiles = Include(@"/*.csv" ) |> SetBaseDir basedir |> Fake.FileSetHelper.ScanImmediately
|> Seq.map Path.GetFileName
|> Set.ofSeq
let set = ["file1 - Copy.csv" ; "file1.csv" ] |> Set.ofSeq
test <@ csvfiles = set @>

[]
let test3 () =
let basedir = SOURCE_DIRECTORY + @"/dirfortesting"
let csvfiles = Include(@"/*.csv" ) |> SetBaseDir basedir |> Fake.FileSetHelper.ScanImmediately
|> Seq.map Path.GetFileName
|> Set.ofSeq
let set = ["file1 - Copy.csv" ; "file1.csv" ] |> Set.ofSeq
test <@ csvfiles = set @>

[] //fails
let test4 () =
let basedir = SOURCE_DIRECTORY + @"/dirfortesting/"
let csvfiles = Include(@"/*.csv" ) |> SetBaseDir basedir |> Fake.FileSetHelper.ScanImmediately
|> Seq.map Path.GetFileName
|> Set.ofSeq
let set = ["file1 - Copy.csv" ; "file1.csv" ] |> Set.ofSeq
test <@ csvfiles = set @>

from fake.

forki avatar forki commented on May 30, 2024

Can retry with the new globbing ?

from fake.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.