Initialize project Guid with empty string about fake HOT 13 CLOSED

Hi,

I don't think I understand your problem completely.
Can you please give more detail?

Cheers,
Steffen

from fake.

I've splittet AssemblyInfo.cs into two parts: AssemblyInfo.cs (with informations about each project) and VersionInfo.cs (global version information in src). Because the GUID (and all the bool flags like ComVisible) depend on the project, they would be defined twice, when Fake generates them for me.
GUID can probably be overwritten by an empty string within build.fsx, but ComVisible not. And it doesn't feel right to declare it globally, does it?

from fake.

There is a ReplaceAssemblyInfoVersions task. Does this help?

from fake.

I don't think so. When I use an empty Guid, it should not write it into the version info. I changed the behaviour of Fake to leave it empty by default. It would be left to discuss if this is ok or leads to problems.

But it does not help for the boolean values, as they are true/false - I cannot blank them afterwards, so they are written always.

from fake.

I think a possible solution would be making all fields in AssemblyInfoParams options, e.g. GenerateClass: bool option.
Then the task would only generate output for the fields that are Some x.
Of course, it's a breaking change...

from fake.

Suggestion: can't the flags changed into nullable bools? And can they set to null by default, and they have to be set when they should be written? Still a breaking change, but...

from fake.

@Slesa yup, that's precisely what I was suggesting... F# devs prefer options to nullable types as they're more general.

from fake.

@mausch I should have read the stackoverflow article more attentively, sorry :-)

from fake.

Ok now I understand it.

Actually I think options would be a good solution. The breaking change is not that big since most scripts don't change the defaults. At least none of my 50 scripts. ;-)

from fake.

what do you think? is this enough?

from fake.

Looks cool, thank you very much. I will try it, but it should work this way.

from fake.

I had to change the GUID again, because this breaks all my scripts ;-) Sorry.

forki@e8f4bd6

But you should still be able to opt out by overwriting the Guid with string.empty.

from fake.

Works great

from fake.