Problems with FSharp.Core versioning when building with Build.cmd about excelprovider HOT 9 CLOSED

You are welcome. The magic is in assembly redirects that I generated automatically using Paket

<dependentAssembly>
  <Paket>True</Paket>
  <assemblyIdentity name="FSharp.Core" publicKeyToken="b03f5f7f11d50a3a" culture="neutral" />
  <bindingRedirect oldVersion="0.0.0.0-65535.65535.65535.65535" newVersion="4.4.1.0" />
</dependentAssembly>

this line tells .net runtime to return v4.4.1.0 to anyone who asks for FSharp.Core.

All other changes are just updates to latest version of libraries and tooling.

from excelprovider.

According to https://fsharp.github.io/2015/04/18/fsharp-core-notes.html you should not rely on GAC in any situation and ship FSharp.Core.dll with application (test proj = application)

@magnushammar Please try code from PR branch, I've updated .net framework to net461 for tests, reference latest FSharp.Core from Nuget, updated NUnit and FsUnit to latest version.

F# 4.1 dll should not be in the GAC

from excelprovider.

It works like a charm with the PR branch and thank you for the link.

Aside from being new to F# I also am quite new to the .Net framework. Trying to figure out the different versions, locations, project formats etc make my head spin far more than F#

Anyway, thank you again!

from excelprovider.

@sergey-tihon Tried the code in your pull request, but failed. Here is the summary:

Running build failed.
Error:
Building C:\Dev\git\ExcelProvider\ExcelProvider.sln failed with exitcode 1.

---------------------------------------------------------------------
Build Time Report
---------------------------------------------------------------------
Target         Duration
------         --------
Clean          00:00:00.0027614
AssemblyInfo   00:00:00.0368392
Build          Failure
Total:         00:00:00.9984879
---------------------------------------------------------------------
Status:        Failure
---------------------------------------------------------------------
---------------------------------------------------------------------
  1) Building C:\Dev\git\ExcelProvider\ExcelProvider.sln failed with exitcode 1.
  2) MSB4057: C:\Dev\git\ExcelProvider\src\ExcelProvider\ExcelProvider.fsproj(0,0): The target "Rebuild" does not exist in the project.
  3) MSB4057: C:\Dev\git\ExcelProvider\tests\ExcelProvider.Tests\ExcelProvider.Tests.fsproj(0,0): The target "Rebuild" does not exist in the project.
---------------------------------------------------------------------

msbuild version: Microsoft (R) Build Engine version 15.1.1012.6693
dotnet: v.1.1.0

from excelprovider.

@AkosLukacs Sorry, but I have no idea how to fix it =(
As you see, build is green on both CI server and my local machine, so the error is somehow related to your local environment.

I saw error The target "Rebuild" does not exist in the project. before, but I have no idea what it the reason and how to fix it in a general way.

from excelprovider.

@sergey-tihon Thanks for the reply!
For reference: just RTFM fsharp.org says Starting with Visual Studio 2017 Update 3, F# is an optional component. Simply select F# from the Individual Components tab and press Install.
VS build tools reinstall solved my issue.

from excelprovider.

@AkosLukacs does it work for you finally?

from excelprovider.

from excelprovider.

I did merge PR with fix and close this issue

from excelprovider.