Giter Club home page Giter Club logo

Comments (5)

eiriktsarpalis avatar eiriktsarpalis commented on May 29, 2024 2

@haf It's just that I think using env vars for parameterization is ugly, violates referential transparency considerations and can be potentially dangerous. If completely unavoidable, I would rather just dereference the vars at the script level and pass through the CLI:

./myApp --foo=$FOO --bar=$BAR

If I am going depend on ambient state for configuration I would much rather have the ability to explicitly specify which aspects of that ambient state I want to use.

Suppose you are consuming an application that I wrote which uses Argu for environment variable parsing. Unbeknownst to you, my application is also looking for a $BAZ environment variable that triggers a functionality you're completely unaware of: let's say it drops the database it connects to once completed. Now, If you were to accidentally expose an export BAZ=true statement in one of your machines, this could carry potentially catastrophic consequences.

The above example by the way is inspired by a true story.

from argu.

eiriktsarpalis avatar eiriktsarpalis commented on May 29, 2024

I'm not the biggest fan of parameterization using env vars. That said, doing it is very simple; you just pass an implementation of IConfigurationReader to the ParseConfiguration method of your parser.

from argu.

haf avatar haf commented on May 29, 2024

Does the GetValue : string -> string return null if it doesn't have it?

Also, what about the #if !CORE_CLR at the top of the parsers? No parsing for .Net core or is it WIP?

Also, why aren't you a fan? I'm interested to know.

from argu.

eiriktsarpalis avatar eiriktsarpalis commented on May 29, 2024

from argu.

haf avatar haf commented on May 29, 2024

You got a PR from me!

from argu.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.