Giter Club home page Giter Club logo

Comments (7)

baronfel avatar baronfel commented on August 16, 2024 1

This is is pretty fundamental protocol-level wrongness, and I think we should crash as a result. There's a difference between well-formed messages that are missing protocol level fields, and not even having well-formed messages.

from fsautocomplete.

baronfel avatar baronfel commented on August 16, 2024 1

Separately, the StreamJsonRpc library has had several revisions ahead of our current version, and the error messages for header parsing have gotten more clear. If we update users might have more of a clear signal about which component is going wrong here.

from fsautocomplete.

vzarytovskii avatar vzarytovskii commented on August 16, 2024

FWIW, tested it just yesterday on the fresh m2, worked quite well. Not sure what's the difference.

from fsautocomplete.

TheAngryByrd avatar TheAngryByrd commented on August 16, 2024

I think this is all runtime related as we've had a few issues pop up that seem to be m1 specific:

Not sure if we can do anything about it since it seems runtime related. Nor do I have an m1 macbook to test these things.

from fsautocomplete.

TheAngryByrd avatar TheAngryByrd commented on August 16, 2024

Haven't had my ☕ but looking at the logs, this seems like a normal error if fsautocomplete doesn't receive the correct input. Which editor are you using with fsautocomplete?

from fsautocomplete.

vzarytovskii avatar vzarytovskii commented on August 16, 2024

This looks awfully similar to #1109

I would assume replit uses some derivative of vscode/vscodium?

from fsautocomplete.

TheAngryByrd avatar TheAngryByrd commented on August 16, 2024

@baronfel i guess this is another case of "should we crash if we get bad data from a client?". Not sure how to gauge this one.

from fsautocomplete.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.