Comments (14)
There is already a dedup/merge for team and loadouts I think
from genshin-optimizer.
I will work on it
from genshin-optimizer.
Actually, importing teams doesn't remove existing teams not in import. Even with the Delete items not in import
option. Same for loadout. Is this behavior intended ?
from genshin-optimizer.
Seems so https://discord.com/channels/785153694478893126/1218906581593231540, tho i still feel like its weird that teams are not deleted with that setting enabled
from genshin-optimizer.
This thread has been marked as not a bug. So, this behavior shouldn't be changed ?
from genshin-optimizer.
Leaving @frzyc to give final say
from genshin-optimizer.
For importing GO data on another GO data for team/loadout, I believe the current logic is the import data overwrite the existing data. I think I am fine with that, deduping would be unnecessarily complicated, the UI should just reflect this.
Yeah i do not think its worth any developer's time to dedup/merge team/loadouts. The ask for this issue is basically just add a tally as a visual for users, and not to add any complex logic to db
from genshin-optimizer.
If no dedup/merge should be done, what will be written on the card ?
from genshin-optimizer.
Just the number of team/loadout/builds before import, and after
from genshin-optimizer.
Also TC Builds ?
from genshin-optimizer.
Yes, and TC builds
from genshin-optimizer.
How the total amout of loadouts can be computed ?
from genshin-optimizer.
yeah loadouts are called teamChars
(due to legacy naming) so it would be database.teamChars.values.length
from genshin-optimizer.
Thanks
from genshin-optimizer.
Related Issues (20)
- Collapsable Talent stat display
- quick character selection in teammate selection UI
- Mobile hamburger menu not scrollable
- Add i18n to Relic Editor
- Create sr-localization library
- SRO crash in weapon page
- Upopt missing a tab title HOT 2
- memory issue on optimize
- Create readme for Somnia
- Lib-ify Somnia
- Export asset data with strings for file names only
- 4star substat needs roll correction
- Change somnia archive passive logic to be similar to constellation
- Add asset pipeline
- Add min/max stat filter UI + database shape
- Add eidolon strings to sr-dm-localization
- Add UI assets to existing elements
- Add basic stat images to sr-assets
- Allow aggregation of Artifact Upgrader data per artifact
- Add library/util to insert stats/scalings into generated templated strings
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from genshin-optimizer.