Giter Club home page Giter Club logo

Comments (14)

CordonZeus22 avatar CordonZeus22 commented on July 19, 2024 1

There is already a dedup/merge for team and loadouts I think

from genshin-optimizer.

CordonZeus22 avatar CordonZeus22 commented on July 19, 2024

I will work on it

from genshin-optimizer.

CordonZeus22 avatar CordonZeus22 commented on July 19, 2024

Actually, importing teams doesn't remove existing teams not in import. Even with the Delete items not in import option. Same for loadout. Is this behavior intended ?

from genshin-optimizer.

nguyentvan7 avatar nguyentvan7 commented on July 19, 2024

Seems so https://discord.com/channels/785153694478893126/1218906581593231540, tho i still feel like its weird that teams are not deleted with that setting enabled

from genshin-optimizer.

CordonZeus22 avatar CordonZeus22 commented on July 19, 2024

This thread has been marked as not a bug. So, this behavior shouldn't be changed ?

from genshin-optimizer.

nguyentvan7 avatar nguyentvan7 commented on July 19, 2024

Leaving @frzyc to give final say

from genshin-optimizer.

frzyc avatar frzyc commented on July 19, 2024

For importing GO data on another GO data for team/loadout, I believe the current logic is the import data overwrite the existing data. I think I am fine with that, deduping would be unnecessarily complicated, the UI should just reflect this.

Yeah i do not think its worth any developer's time to dedup/merge team/loadouts. The ask for this issue is basically just add a tally as a visual for users, and not to add any complex logic to db

from genshin-optimizer.

CordonZeus22 avatar CordonZeus22 commented on July 19, 2024

If no dedup/merge should be done, what will be written on the card ?

from genshin-optimizer.

frzyc avatar frzyc commented on July 19, 2024

Just the number of team/loadout/builds before import, and after

from genshin-optimizer.

CordonZeus22 avatar CordonZeus22 commented on July 19, 2024

Also TC Builds ?

from genshin-optimizer.

frzyc avatar frzyc commented on July 19, 2024

Yes, and TC builds

from genshin-optimizer.

CordonZeus22 avatar CordonZeus22 commented on July 19, 2024

How the total amout of loadouts can be computed ?

from genshin-optimizer.

frzyc avatar frzyc commented on July 19, 2024

yeah loadouts are called teamChars(due to legacy naming) so it would be database.teamChars.values.length

from genshin-optimizer.

CordonZeus22 avatar CordonZeus22 commented on July 19, 2024

Thanks

from genshin-optimizer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.