Giter Club home page Giter Club logo

Comments (3)

frzi avatar frzi commented on May 30, 2024 2

A single Switch with a large number of Routes as its descendants would indeed have an (albeit tiny) impact on performance. For this it's advised to slice your routing in multiple Switches to utilize early elimination.

Taking your initial example: an app that has a route for each tab, you could implement the navigation similar to:

// Create routes for every tab in the app.
struct RootView: View {
    var body: some View {
        Switch {
            Route(path: "/news", content: NewsView)
            Route(path: "/finances", content: FinancesView)
            Route(path: "/twitter", content: TwitterView)
            // etc...
        }
    }
}

// Create routes for the news tab.
struct NewsView: View {
    var body: some View {
        Switch {
            Route(path: "/news/latest", exact: true, content: LatestNewsView)

            // Parameter variables coming in a future version. :)
            Route(path: "/news/:newsId", exact: true) { routeProps in 
                NewsItemView(id: routeProps.params.newsId)
            }

            // Default view.
            Route(content: NewsHomeView)
        }
    }
}

(Pardon the crude example 😅)

Let's say the app's current path was /finances. In the first Switch, the /news Route will be tested, fail, and prevent the need to test all sub-routes in NewsView.

By splitting the branches into multiple views (and thus multiple Switches) you utilize early elimination, preventing a Switch from checking for (too many) unnecessary routes. This should help performance wise while also making the code easier to read.

Anyway, thanks for checking out SwiftUI Router! 😄

from swiftui-router.

jrames avatar jrames commented on May 30, 2024 1

Explained it perfectly, thanks!

The Groups seem like a decent workaround, especially if the implementation details are abstracted into something prettier. Still a bit fragile looking and I wonder if there could be performance impacts for a switch with an especially large about of routes.

Appreciate the POC and the clarification 👍

from swiftui-router.

frzi avatar frzi commented on May 30, 2024

The limit of 10 direct descendant views comes from the limitation of @ViewBuilder and TupleView. You can theoretically have infinite routes in your app. But like every other View using @ViewBuilder (like Group, HStack, VStack, etc.) you can't put more than 10 Routes as direct descendants in a Switch. This isn't a limit of SwitchUI Router, but rather a limit in SwiftUI (and I think Swift 5.1 at this point?)

To illustrate:

Switch {
    // You can only put a maximum of 10 children here.
}

To bypass this limitation, you should be able to divide your collection of Routes in Groups!

Switch {
    Group {
        // Put your first 10 Routes here
    }
    Group {
        // ...the next 10 Routes here
    }
    // Etc for a maximum of 10 Groups.
}

Hopefully I explained this clearly enough. 😄

from swiftui-router.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.