Comments (19)
Thanks for all! Your project is great and I'm really happy that I could help a little with it
Thank you so much, Jen!
All the best, and Congratulations on your amazing work!
from ff-web.
Also hello, Progress!
from ff-web.
Hi, you'll need mitt to allow the localization drop down to refresh the page, paired with i18n - previously we used EventBus for the refresh but it's deprecated in Vue 3.
I created a branch for this work as it's kind of big
from ff-web.
I would love to work on this
from ff-web.
Please do! This is a big job but i18n with translations.js files should do the trick! Thanks!
from ff-web.
I am super new to this. I think I misunderstood what I was signing up for, and do not fully understand the ask. Could you explain this a little more?
from ff-web.
Hi, a full site translation is not an easy first contribution... you'll need to install a plug-in to make it work and then all hard coded strings need to be translated, with translations stored in separate folders. It's a pretty big job - previously we had it done - it's in our /website repo
from ff-web.
If someone else wants to take this up feel free, and I can learn from what you do. I am going to give this a try but not sure I could complete the whole thing.
from ff-web.
@jlooper Why would you use mitt?
from ff-web.
Hi!
I have no idea, someone still working with it. In any case, I was working with the translations (English and Spanish) on some pages (Home and Sponsors). This is the result. I don't know if it is expected. Could you please review it?
I needed some changes to the base code:
- Updated "vue-i18n" dependency to "vue-i18n@next", because "vue-i18n" isn't ready yet to Vue 3 (I read some issues), because I have problems with the previous version.
- Added a "new idea" to organize the translations and change .js to .json.
- Added some language flags on the header to change the languages.
What do you think about these changes? Maybe, there are better solutions, it's only my suggestion.
Thanks!
Note.- If it's OK, I still need review sentences, grammar, etc., and I have to think about how we can apply some translation on iterate data and complete all translations.
from ff-web.
hi! Wow, this is looking very promising!
I am hoping that we can port over all the translations we did here:
https://github.com/FrontEndFoxes/website/tree/main/assets/translations
and use "flag-icon-css": as per the old package.json, if we can, as a flag dropdown
I think we should do these translations on branches, so that we can get reviewers to QA them (Spanish/Portuguese/French/Japanese to start - I don't think we need to differentiate pt-br from pt; and I want an American flag for English :) - small details ). I will ask our Japanese chapter to take a look at adding Japanese translations.
Here's the code for the actual dropdown: here's where we need mitt to help with page refresh, looks like you got that working!!
https://github.com/FrontEndFoxes/website/commit/f8653a13cee0d08c135d80b5a92632b489323cff#diff-2bf98384263cf7fd15d9de005781efbe (this was the moment we removed them as it was hard to maintain)
from ff-web.
I am hoping that we can port over all the translations we did here
Hi!
Great ideas and corrections! Thank you so much! I'll apply them.
- About the translations, yes I used some values from the translations folder, but I've applied a different folder structure:
src
|___ i18n/
|____ en/
|____ en-header.json
|____ en-home.json
|____ en-footer.json
|____ ...
|____ es/
|____ es-header.json
|____ es-home.json
|____ es-footer.json
|____ ...
I think It can be a little more organized, and maybe maintainable because you could organize the Translation Reviewer teams in the future easily.
For example:
- English team -> /en
- Spanish team -> /es
- Japan team -> /jp
- etc.
But, I can change to the original idea., No problem. What do you think about it?
Thanks!
Note.- I still have to think about how we can apply some translations on iterate or dynamic data. Please, if you have some ideas, I'll appreciate it Also, I have to complete all missing translations.
from ff-web.
I like your organization idea, it's better than longer and longer translation files! nice one!
I think you're wondering about the translations for the .json data, like the .json files for Event Gallery. Hmm. One thing I was thinking is not bothering translating those, as they are just event names which won't have a translation and the city/country can stay per se. I think this will be more maintainable, as every time I add an event I'd potentially have to add translations to three or four different files, it's not worth it. I think it's ok to translate the important parts of the site (H1 headers and the About page, mostly, and the home page).
Does that sound right to you?
Thank you again!!
from ff-web.
I like your organization idea, it's better than longer and longer translation files! nice one!
I think you're wondering about the translations for the .json data, like the .json files for Event Gallery. Hmm. One thing I was thinking is not bothering translating those, as they are just event names which won't have a translation and the city/country can stay per se. I think this will be more maintainable, as every time I add an event I'd potentially have to add translations to three or four different files, it's not worth it. I think it's ok to translate the important parts of the site (H1 headers and the About page, mostly, and the home page).
Does that sound right to you?
Thank you again!!
Hi!
Good news! I was working the translations. I believe that happily more sections are translated such as cards, it's amazing to me!!!.
Example: Spanish translations are 95%, it's possible there are some mistakes. But, I think the most important thing is done. How do we change between languages?.
Now, we can choose between four languages: English, Spanish, French, and Portuguese.
Could you please review this new version? I'll appreciate it.
I feel that we're near to finish this issue. But, I'm open to new ideas, corrections, improvements, etc. I'm happy!!!
Thanks!
Note.- I think that we'll need help to support other languages, and QA to review our translations, because my native language is Spanish, and I know a little English
from ff-web.
this is wonderful, and the language dropdown works great! We might need to rely on our chapter leaders to correct our translations. I'm just not sure about the Portuguese. Let me open some issues!
Really appreciate all this work!
from ff-web.
Hi!
Thanks for your words!
Your page is more incredible and complete every day. Congratulations!
Do you think this version is ready for some pull request and more people can contribute or review the translations? Which branch should you use? or do you have some additional comments or suggestions?
Thanks!
Note.- There are many changes to base code
from ff-web.
hi, would you like to make a PR for the base code, and I think I'll make branches for each translation as we roll them in progressively. Let's start with English and Spanish committed to 'main' and I'll branches for French, Portuguese, and Japanese so we can enhance the site progressively. Many thanks again!
from ff-web.
hi, would you like to make a PR for the base code, and I think I'll make branches for each translation as we roll them in progressively. Let's start with English and Spanish committed to 'main' and I'll branches for French, Portuguese, and Japanese so we can enhance the site progressively. Many thanks again!
I'm so sorry for my delay with the PR
Also, I wrote a little guide to translations maintainers. I hope It's useful.
Fortunately, the PR is now on Github
Thanks for your time, support, and help! Have a nice day!
from ff-web.
I have no words.... I'm just amazed by the amount of work here. Thank you so much, Alejandro!!!
Just amazed
from ff-web.
Related Issues (20)
- Changes to top Navigation HOT 1
- Complete Teams page migration HOT 6
- 404 page/ Netlify routes HOT 1
- Add topic `hacktoberfest` HOT 1
- Set up unit tests HOT 2
- Implement 404 page HOT 3
- QA for French translations HOT 5
- QA for Portuguese translations
- Japanese translations HOT 2
- Russian translations HOT 1
- Metadata clean-up HOT 2
- About us page tidy-up HOT 25
- Standardize button format on home page HOT 5
- Put a little loader on images in cards HOT 3
- Refactor localization in Gallery a little
- Oops! Comment out megaphone icon as Iām not publishing a newsletter right now (in footer) HOT 2
- on iPad, Team cards are being cut off HOT 5
- re-color links HOT 3
- The home page cards don't scale easily if there are more than four or fewer than a multiple of four HOT 5
- QA Spanish language HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
š Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ššš
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ā¤ļø Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ff-web.