Idea: put default amount of keep_results into a variables file about klippain-shaketune HOT 5 OPEN

Hi, thanks for the suggestion, and yes this is something already in my backlog. It was just not the priority but I definitely want to add this.

I'm really open for a PR if you want to work on this :)
Also, at the same time I wanted to have the accelerometer chip name and the "keep_csv" in this variable in the same way. And maybe define a main read-only file as a simlink with default value that one could copy paste and override in his config if needed. What do you think about this? It would make it easier for updates and avoid potential breaking changes.

from klippain-shaketune.

Hi, thanks for the suggestion, and yes this is something already in my backlog. It was just not the priority but I definitely want to add this.

I'm really open for a PR if you want to work on this :) Also, at the same time I wanted to have the accelerometer chip name and the "keep_csv" in this variable in the same way. And maybe define a main read-only file as a simlink with default value that one could copy paste and override in his config if needed. What do you think about this? It would make it easier for updates and avoid potential breaking changes.

Sounds good, havent thought about those two as well but makes sense to also make them "static"
I would also add a version variable to it which gets checked on startup, to prevent mishaps (like I am doing here: https://github.com/LynxCrew/Klicky/blob/main/Variables/homing_variables.cfg)
I'll get to it later and write the code for it

from klippain-shaketune.

PR is out

from klippain-shaketune.

could you please link your PR to the issue or vice versa? Thanks :)

from klippain-shaketune.

@Surion79 #48

from klippain-shaketune.