Using [adxl345 my_custom_name] doesn't work for vibrations graphs about klippain-shaketune HOT 7 OPEN

If I rename "adxl345-toolboard-sp20_00n1.csv" to "toolboard-sp20_00n1.csv"the files in the /tmp folder, the program works and generate the plot...

from klippain-shaketune.

Hello,
I don't think you are doing something wrong but currently custom named accelerometer doesn't work for the vibration graphs.

So if you have something like [adxl345 whatevername], this will not work. Shake&Tune is for now compatible only with vanilla [adxl345] or [lis2dw], etc... without any custom name. But I already have it in the backlog and do plan on working on this subject soon.

The main problem I need to overcome is that whatevername can be either an adxl345 or a lis2dw or any other Klipper supported accelerometer and it will change the CSV filename. So I need to find a way in my Klipper macro to be able to detect which chip is associated with this custom name in order to pass it to my Python scripts to look for the correct csv filenames and I'm not sure how to do this at the moment...

from klippain-shaketune.

This is my attempt to fix this.
What it does it is checks to see if adxl_y is the same as adxl_x if true then it just does normal operation.
if adxl_y is not the same as adxl_x then it will run X with adxl_x and Y with adxl_y

K-SnT_vibrations - seperate adxl for x and y.txt

from klippain-shaketune.

i've modified is_workflow.py line 139
from:
globbed_files = glob.glob(f'/tmp/{chip_name}-.csv')
to:
globbed_files = glob.glob(f'/tmp/adxl345-{chip_name}-.csv')

now VIBRATIONS_CALIBRATION ACCEL_CHIP=toolboard
works perfectly

from klippain-shaketune.

will this work for lis2dw also, or is adxl fixed in there

from klippain-shaketune.

Hey @Frix-x thanks for this awesome module! Currently this issue also affects bed slingers as well since you need 2 adxls by necessity (one for toolhead and one for the bed).

I'll take a look at the code and see if I can at least fix this for bedflingers (which we could enforce a set "toolhead" and "bed" naming scheme to have it follow a convention S&T can follow

from klippain-shaketune.

Hey @Frix-x thanks for this awesome module! Currently this issue also affects bed slingers as well since you need 2 adxls by necessity (one for toolhead and one for the bed).

I'll take a look at the code and see if I can at least fix this for bedflingers (which we could enforce a set "toolhead" and "bed" naming scheme to have it follow a convention S&T can follow

Thanks for the proposal.
I have a plan already but need to find time to work on it. But to sum up, I want to retrieve the acelerometer type from the Klipper macro by using jinja and looking at the "printer" object in order to send it to the Python script and replace the hardcoded "adxl345" string with this. If you find out how to do this, it would be wonderful and I'll be happy to accept a PR :)

from klippain-shaketune.