Unable to produce graph for v0.2 y-axis - AttributeError: 'NoneType' object has no attribute 'upper' about klippain-shaketune HOT 7 CLOSED

Same here, or looks at least the same:

17:53
Command {plot_graph} finished
17:53
peaks = plot_freq_response_with_damping(ax1, calibration_data, shapers, selected_shaper, fr, zeta, max_freq)
File "/home/fly/klippain_shaketune/K-ShakeTune/scripts/graph_shaper.py", line 245, in plot_freq_response_with_damping
ax2.plot([], [], ' ', label="Recommended low vibrations shaper: %s @ %.1f Hz" % (no_vibr_shaper.upper(), no_vibr_shaper_freq))
AttributeError: 'NoneType' object has no attribute 'upper'
17:53
fig, png_filename = get_shaper_graph()
File "/home/fly/printer_data/config/K-ShakeTune/scripts/is_workflow.py", line 116, in get_shaper_graph
fig = shaper_calibration([new_file], KLIPPER_FOLDER)
File "/home/fly/klippain_shaketune/K-ShakeTune/scripts/graph_shaper.py", line 338, in shaper_calibration
17:53
Traceback (most recent call last):
File "/home/fly/printer_data/config/K-ShakeTune/scripts/is_workflow.py", line 231, in
main()
File "/home/fly/printer_data/config/K-ShakeTune/scripts/is_workflow.py", line 217, in main
17:53
Fitted shaper 'zv' frequency = 25.6 Hz (vibrations = 27.7%, smoothing ~= 0.235)
To avoid too much smoothing with 'zv', suggested max_accel <= 2200 mm/sec^2
Fitted shaper 'mzv' frequency = 33.0 Hz (vibrations = 11.1%, smoothing ~= 0.187)
To avoid too much smoothing with 'mzv', suggested max_accel <= 3200 mm/sec^2
Fitted shaper 'ei' frequency = 43.6 Hz (vibrations = 12.0%, smoothing ~= 0.169)
To avoid too much smoothing with 'ei', suggested max_accel <= 3500 mm/sec^2
Fitted shaper '2hump_ei' frequency = 47.0 Hz (vibrations = 5.0%, smoothing ~= 0.244)
To avoid too much smoothing with '2hump_ei', suggested max_accel <= 2400 mm/sec^2
Fitted shaper '3hump_ei' frequency = 49.2 Hz (vibrations = 1.7%, smoothing ~= 0.339)
To avoid too much smoothing with '3hump_ei', suggested max_accel <= 1600 mm/sec^2
Recommended shaper is 3hump_ei @ 49.2 Hz
Axis has a main resonant frequency at 30.7Hz with an estimated damping ratio of 0.065
Peaks detected on the graph: 5 @ 30.7, 54.9, 75.9, 95.3, 124.3 Hz (5 above effect threshold)

from klippain-shaketune.

Hey, thanks for raising an issue. I'll try to reproduce it on my side (thanks for the CSV) and will fix it as soon as possible :)

from klippain-shaketune.

Similar problem on Klippain HappyHare

from klippain-shaketune.

same problem

00:47:16
Command {plot_graph} finished
00:47:16
main()
File "/home/pi/printer_data/config/K-ShakeTune/scripts/is_workflow.py", line 217, in main
fig, png_filename = get_shaper_graph()
File "/home/pi/printer_data/config/K-ShakeTune/scripts/is_workflow.py", line 116, in get_shaper_graph
fig = shaper_calibration([new_file], KLIPPER_FOLDER)
File "/home/pi/klippain_shaketune/K-ShakeTune/scripts/graph_shaper.py", line 338, in shaper_calibration
peaks = plot_freq_response_with_damping(ax1, calibration_data, shapers, selected_shaper, fr, zeta, max_freq)
File "/home/pi/klippain_shaketune/K-ShakeTune/scripts/graph_shaper.py", line 245, in plot_freq_response_with_damping
ax2.plot([], [], ' ', label="Recommended low vibrations shaper: %s @ %.1f Hz" % (no_vibr_shaper.upper(), no_vibr_shaper_freq))
AttributeError: 'NoneType' object has no attribute 'upper'
00:47:16
Fitted shaper 'zv' frequency = 38.6 Hz (vibrations = 7.5%, smoothing ~= 0.107)
To avoid too much smoothing with 'zv', suggested max_accel <= 5800 mm/sec^2
Fitted shaper 'mzv' frequency = 24.4 Hz (vibrations = 5.4%, smoothing ~= 0.342)
To avoid too much smoothing with 'mzv', suggested max_accel <= 1700 mm/sec^2
Fitted shaper 'ei' frequency = 36.4 Hz (vibrations = 4.9%, smoothing ~= 0.243)
To avoid too much smoothing with 'ei', suggested max_accel <= 2500 mm/sec^2
Fitted shaper '2hump_ei' frequency = 43.2 Hz (vibrations = 4.5%, smoothing ~= 0.289)
To avoid too much smoothing with '2hump_ei', suggested max_accel <= 2000 mm/sec^2
Fitted shaper '3hump_ei' frequency = 53.0 Hz (vibrations = 4.4%, smoothing ~= 0.292)
To avoid too much smoothing with '3hump_ei', suggested max_accel <= 1900 mm/sec^2
Recommended shaper is zv @ 38.6 Hz
Axis has a main resonant frequency at 39.2Hz with an estimated damping ratio of 0.050
Peaks detected on the graph: 3 @ 6.3, 39.2, 50.2 Hz (2 above effect threshold)
Traceback (most recent call last):
File "/home/pi/printer_data/config/K-ShakeTune/scripts/is_workflow.py", line 231, in

from klippain-shaketune.

Hello everyone,

Thanks for the feedback. I indeed identified a bug in the "low vibration" shaper recommendation that can happens when there is no shaper with a low level of remaining vibration available.
I changed the logic a little bit to be smarter and make better suggestion. This is available in the develop branch for now but I'll merge it in a couple of minutes.

@AMFkuna the bug you are experiencing is due to another problem that is already fixed here but not pushed in the main Klippain repository (and its HappyHare branch) for now. It will be done tomorrow alongside the new full Klippain release :)

from klippain-shaketune.

Fixed in v1.1.0 !

from klippain-shaketune.

Fixed in v1.1.0 !

Thank you very much! Going to test it now! :)

//edit: Works!

from klippain-shaketune.