3.4.0 not working with Symfony 6.4 about fosjsroutingbundle HOT 11 CLOSED

I'm having the same issue. The regression was introduced in 23b8ec9.

from fosjsroutingbundle.

Same issue. Downgrade to 3.3.0 solved the issue.

from fosjsroutingbundle.

Same issue here too. Revert to previous version.

from fosjsroutingbundle.

@ar10642, can you review this issue? Thanks!

from fosjsroutingbundle.

OK maybe this doesn't work as expected, although all tests passed for me. Possibly some situation not covered by the tests. We are using Symfony 5.4 and didn't have any errors. I don't have any Symfony 6.4 projects I can try this with right now. Might need to revert?

from fosjsroutingbundle.

@ar10642, here is a reproducer with Symfony 5.4: https://github.com/ajgarlag/FOSJsRoutingBundle/blob/issue-473-reproducer/README.md

The diff between the working and failing commits is ajgarlag@4e83701

Hope this can help you or any other developer to fix the bug.

from fosjsroutingbundle.

Hi all,

First of all, this is independent of the Symfony version as the only thing that was broken is the Webpack integration.
@ajgarlag thanks for the reproducer, that was actually of great help.
The problem was that the previous implementation of the Webpack plugin (which is a part of the bundle which is not included in the automated tests) would actually inject the generated files, but the BannerPlugin is only meant to prepend or append text in a built file.
I have found a fork of the original plugin which doesn't seem abandoned, and doesn't rely on the vulnerable dependency for which the original action was executed.
Please try release 3.4.1 and let me know, I myself don't use the Webpack plugin so it's hard for me to test in an actual application.

from fosjsroutingbundle.

@tobias-93

3.4.1 is working for me. thank you for the fix!

from fosjsroutingbundle.

@craigh thanks for the feedback, closing the issue.

from fosjsroutingbundle.

from fosjsroutingbundle.

@tobias-93 Thanks for the fix. It works fine!

from fosjsroutingbundle.