Giter Club home page Giter Club logo

Comments (16)

Coledunsby avatar Coledunsby commented on July 4, 2024

Are you using the code from the latest commit? I haven't updated the pod spec yet.

from lgsidemenucontroller.

vinecole27 avatar vinecole27 commented on July 4, 2024

LGSideMenuController (1.0.10)
this is what pod installed

from lgsidemenucontroller.

Coledunsby avatar Coledunsby commented on July 4, 2024

I have not created a new version yet including the fix. In the meantime you can include the pod like this to get the latest changes:

pod 'LGSideMenuController', :git => 'https://github.com/Friend-LGA/LGSideMenuController.git'

I will keep this issue open until I create a new cocoapod release.

from lgsidemenucontroller.

vinecole27 avatar vinecole27 commented on July 4, 2024

ok, thanks

from lgsidemenucontroller.

vinecole27 avatar vinecole27 commented on July 4, 2024

@Coledunsby I tried with above pod update but doesn't work

from lgsidemenucontroller.

Coledunsby avatar Coledunsby commented on July 4, 2024

I'll have another look

from lgsidemenucontroller.

vinecole27 avatar vinecole27 commented on July 4, 2024

anything found?

from lgsidemenucontroller.

vinecole27 avatar vinecole27 commented on July 4, 2024

@Coledunsby I found what caused an issue, line 502 on LGSideMenuController.m should be replaced with
[self.view insertSubview:_rootViewCoverViewForRightView aboveSubview:_rootViewCoverViewForRightView];

from lgsidemenucontroller.

vinecole27 avatar vinecole27 commented on July 4, 2024

can you make a quick change and commit?

from lgsidemenucontroller.

Coledunsby avatar Coledunsby commented on July 4, 2024

It doesn't make sense to insert the subview above itself. I need some more context about your problem to resolve it. What LGSideMenuPresentationStyle are you using? Can you reproduce it in the demo app?

from lgsidemenucontroller.

vinecole27 avatar vinecole27 commented on July 4, 2024

original line was
[self.view insertSubview:_rootViewCoverViewForRightView aboveSubview:_rootViewCoverViewForLeftView]; which _rootViewCoverViewForLeftView is nil
it should be _rootViewCoverViewForRightView

from lgsidemenucontroller.

Coledunsby avatar Coledunsby commented on July 4, 2024

fixed

from lgsidemenucontroller.

vinecole27 avatar vinecole27 commented on July 4, 2024

thanks

from lgsidemenucontroller.

vinecole27 avatar vinecole27 commented on July 4, 2024

***I will keep this issue open until I create a new cocoapod release.

I see you closed this issue, have you already updated pod version?

from lgsidemenucontroller.

murali9 avatar murali9 commented on July 4, 2024

Why shadow for right view controller is not coming ?
i used the below code.

self.rootViewLayerShadowColor = [UIColor blackColor];
self.rootViewLayerShadowRadius = 20;

from lgsidemenucontroller.

murali9 avatar murali9 commented on July 4, 2024

Fixed . we have to upgrade to 2.0.4 library

from lgsidemenucontroller.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.