use torch-cam/scripts/cam_example.py throw a exception: about torch-cam HOT 5 CLOSED

from torch-cam.

Hello @Ethan-Chen-plus 👋

Thanks for reporting this!
I just investigated and here is what happened:

• in order to save memory for users, I started removing unnecessary gradient computation in scripts
• now this library uses pytorch hooks, and some hooks (including the ones I use to store gradients) throw errors if the output tensor doesn't have requires_grad set to True
• so far so good, because for each input tensor I set its requires_grad to True (we avoid the grad computation for each model's parameter that way, which can save a lot of memory depending on the model size)
• however, after investigating your problem, I realized the script was failing on SmoothGradCAMpp which is a bit specific. It creates a noisy input that will be forwarded into the model. And I had forgotten to set the grad computation there (until now, it couldn't crash because everything else was requiring gradient so the hook couldn't crash)

As this is pretty simple to fix, I just opened a PR (#204) to address this! This should be solved on the "main" branch within a few minutes :)

Let me know if you have any questions!

from torch-cam.

Good! Thank you for solving this!

from torch-cam.

Thank you for solving this problem!
However in current version(2023-02-05), this bug is not fixed in current main branch, and thus I've spent several hours debugging until coming across this issue. Therefore it is recommended that this small bug be fixed as soon as possible to help new rookies to save time. THX a lot.

from torch-cam.

Hi @zhangzw12319 👋

What do you mean?
About the specific bug mentioned in this very issue, I merged the PR fixing it 3 weeks ago and I just tried again the exact same snippet, it works correctly 🤔
Perhaps it's because you're using the last published version of the library? Does the problem persist if you install it in developer mode first?

git clone https://github.com/frgfm/torch-cam.git
pip install -e torch-cam/.

If you're referring to another bug or another snippet, this might be unrelated and in this case, feel free to open another issue :)

from torch-cam.