underscore templates are not working in Autherization_Url about marketplace-sample-apps HOT 13 CLOSED

It must work. We do support templating in authorize and token url. Do you get any error while testing?

from marketplace-sample-apps.

from marketplace-sample-apps.

Are you using the latest version of the fdk?

from marketplace-sample-apps.

Yes, i tried in 4.1.5 and 4.1.7

from marketplace-sample-apps.

Please ensure you have provided authorize_url as https://login.teamviewer.com/oauth2/authorize and the token_url as https://login.teamviewer.com/api/v1/oauth2/token in oauth_config.json

from marketplace-sample-apps.

{
"client_id": "<%= oauth_iparams.client_id %>",
"client_secret": "<%= oauth_iparams.client_secret %>",
"authorize_url": "https://login.teamviewer.com/oauth2/authorize?response_type=code&client_id=<%= oauth_iparams.client_id %>&redirect_uri=http%3A%2F%2Flocalhost%3A10001%2Fauth%2Fcallback",
"token_url": "https://webapi.teamviewer.com/api/v1/oauth2/token",
"options": {},
"token_type": "account",
"oauth_iparams": {
"client_id": {
"display_name": "client_id",
"description": "Please enter your client_id",
"type": "text",
"required": true
},
"client_secret": {
"display_name": "client_secret",
"description": "Please enter your client_secret",
"type": "text",
"required": true
}
}
}

my teamviewer api needs have client_id in authorize_url
See my API ref:GET login.teamviewer.comoauth2/authorize?response_type=code&client_id=12333-
133Ea4Hdf3e9ec0543fX&redirect_uri=https%3A%2F%2Fclient%2Eexample%2Ecom%2Fcb

from marketplace-sample-apps.

From the configuration that you have provided, it seems like you have used templating in client_id and client_secret which is not supported. Please replace it with actual client_id and client_secret values. The authorize and token URL must be changed to the ones that I have provided.

from marketplace-sample-apps.

first point: Then how it will work as dynamic OAuth authentication.You are suggesting me to hard code the client_id and client_secret.I confirmed with you one of your developers he said "templating only works in client_id and client_secret".
second point: If I replace as suggested then what about the parameter that my API is expecting to have in autherize_url?

from marketplace-sample-apps.

Regarding OAuth, the developer of the app must provide in the client_id and client_secret. The user who installs the app is not expected to provide these credentials.

The parameters that need to be passed through the authorize URI will be taken care by our OAuth authentication system. The parameters that you referred in the documentation is supposed to be provided if the OAuth flow is done manually without a client. In our case all the actions are handled by an OAuth client.

from marketplace-sample-apps.

Let me ask the last question.
I have given client_id and client_secret fields if any customer installed my app then how he will provide client_id and client_sercret of his app?

from marketplace-sample-apps.

As i told, the client id and secret must be provided by the developer of the app and not by the user.

Client ID and secret stand to identify your app(that you have developed) uniquely. And must not be specific to user.

from marketplace-sample-apps.

ok thanks.

from marketplace-sample-apps.

Hope it helped. Im closing the issue.

from marketplace-sample-apps.