Giter Club home page Giter Club logo

Comments (8)

sarfaraz187 avatar sarfaraz187 commented on May 31, 2024 1

Hello saif,
I would like to contribute in building this app. If you have any plan in mind for the app can you direct me towards it?

from marketplace-sample-apps.

Saif-Shines avatar Saif-Shines commented on May 31, 2024 1

That works @sarfaraz187 , anything as per your convenience.

from marketplace-sample-apps.

sarfaraz187 avatar sarfaraz187 commented on May 31, 2024 1

Hello @Saif-Shines,

Started working on Freshchat App Request and have implemented some of the features that had been requested. Kindly review the application and let me know your feedback Git Repo.

Here are few questions in which your suggestions can be helpful.

  1. Contact information displayed in modal is it sufficient?
  2. Since i am not any sending data back from modal to parent i haven't used instance API.
  3. Is it fine to display the last 5 lookups in app itself or should i display in modal?

from marketplace-sample-apps.

Saif-Shines avatar Saif-Shines commented on May 31, 2024 1

Hey @sarfaraz187,

Raise a PR and let's have it merged. Then we will focus on improvements gradually. 😄

from marketplace-sample-apps.

Saif-Shines avatar Saif-Shines commented on May 31, 2024

Hi @sarfaraz187 ,

This issue was created initially not for Hacktoberfest purpose, so this might require lot of time and effort. So you may choose to implement the aspects those will fit your time an expertise.

Having said that I will include it for hacktoberfest and let you know some of my thoughts that can help you as you plan to take it on.

  1. App can use the placeholder in Inbox Page.
  2. Use crayons to quickly build up a small form that takes in email, twitter_id and Fullname.
  3. Use Request Method to make an request and store last 5 responses in Data Store.
  4. This data got in response can be passed on to an Modal via Instance Method.

When this issue was created, Enrich API was free for developers to use to grab little details. I will let you choose any API that can be helpful that is free. The Goal is to demonstrate the features for others in the community to refer to. So having the part of just using Request Method is good enough without having to build complete app.

from marketplace-sample-apps.

sarfaraz187 avatar sarfaraz187 commented on May 31, 2024

Hello @Saif-Shines ,

Thanks for your suggestions and assigning me this App. Yes Saif i will keep in mind the time and effort required. As you have suggested will work on one module at a time.
Regarding the Enrich API,

  • Had gone through the documentation and was planning to use Multi Field Request API.
  • Enrich requires an API key in order to fetch data. Shall i setup an Iparams page to get the Enrich API key from the user. Let me know you thoughts on this?

from marketplace-sample-apps.

Saif-Shines avatar Saif-Shines commented on May 31, 2024

Hi @sarfaraz187 ,

We went through the code. Although there is a room for improvement, none of it is a blocker to have your code on this repository. If there is nothing else you'd add or subtract, please rase a PR adding app's code to Demo Apps folder.

Really appreciate your efforts and taking time to contribute.

from marketplace-sample-apps.

sarfaraz187 avatar sarfaraz187 commented on May 31, 2024

Hi @Saif-Shines,

Thanks for the update. If you have any suggestions for improvement do let me know or else if you had in mind for others in our community to contribute in the improvement of this app i'll be more than happy to raise PR request with the current version.

from marketplace-sample-apps.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.