Giter Club home page Giter Club logo

Comments (4)

 avatar commented on May 25, 2024 2
  • Can we have 'mode' as and attribute that can have 'range' and other attributes instead of specifying singledatepicker?

okay I'll rename and change the boolean type to string with ('range'/'single date')

  • missing things like value. To fetch the date.

I thought of reuse startDate as value for singleDate(not good idea though). I'll add value which is for mode 'single date'

  • If you are doing time selection, do we need to add more attributes?

startTime and endTime attributes only will be extra to it for time selection.

  • Should component be compatible with i18n?

I do have that doubt, if it's okay to add in next update, we can hold.

  • fwChange

will rename the event name

from crayons.

asif-ahmed-1990 avatar asif-ahmed-1990 commented on May 25, 2024

@sathishkumar-thangavel A few doubts questions:

  • Can we have 'mode' as and attribute that can have 'range' and other attributes instead of specifying singledatepicker?
  • missing things like value. To fetch the date.
  • If you are doing time selection, do we need to add more attributes?
  • Should component be compatible with i18n?
  • fwChange

from crayons.

 avatar commented on May 25, 2024

@asifahmedfw as I'm discussed with designer, timepicker can be a seprate component, people mostly not using and it'll be complex. So updated the properties above( removed timepicker properties)

from crayons.

asif-ahmed-1990 avatar asif-ahmed-1990 commented on May 25, 2024

@sathishkumar-thangavel There is already a timepicker. Datepicker needs to have a timepicker. You can take that in second phase but make sure no interface changes when you introduce timepicker.

from crayons.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.