Describe the bug I find it misleading that when previewing a CSS s

The article selector works like a charm, but as <a class="user-mention notranslate" da

<span aria-label="This issue is a duplicate of #6228" class="issue-keyword tooltipped

Please try <a class="issue-link js-issue-link" data-error-text="Failed to load title"

Thanks for the feedback. Please try <a class="issue-link js-issue-link" data-error-tex

[Bug] Preview of CSS selector uses the one saved and not the one entered about freshrss HOT 7 CLOSED

Alwaysin commented on June 18, 2024

[Bug] Preview of CSS selector uses the one saved and not the one entered

from freshrss.

Comments (7)

Alwaysin commented on June 18, 2024 2

It works perfect, thank you!

from freshrss.

Alwaysin commented on June 18, 2024 1

Thank you, works like a charm!
It is not supposed to take "CSS selector of the elements to remove" into account, right? Is it wortt opening an issue about it?

from freshrss.

mrnoname1000 commented on June 18, 2024 1

The article selector works like a charm, but as @Alwaysin mentions, the removal selector is not taken into account for the preview. I would argue this is even more surprising behavior and still a bug.

I would also like to note that testing is made more difficult due to #6229 as any > operators are mangled, breaking most of the article selectors for my feeds.

from freshrss.

math-GH commented on June 18, 2024

Duplicate of #6228

from freshrss.

math-GH commented on June 18, 2024

First look into the code:

The selector is used only for showing an error message, if the current selector is empty

FreshRSS/app/Controllers/feedController.php

Lines 1114 to 1119 in 8280e3d

 $content_selector = Minz_Request::paramString('selector'); 

 if (!$content_selector) { 

 $this->view->fatalError = _t('feedback.sub.feed.selector_preview.selector_empty'); 

 return; 

 }

Then everything is fetched from the database.

selector_filter=selector-filter-token is set in the link for the preview, but nowhere used. It looks like a stump from #4501

from freshrss.

Alkarex commented on June 18, 2024

Please try #6423

from freshrss.

Alkarex commented on June 18, 2024

Thanks for the feedback. Please try #6426

from freshrss.

Recommend Projects

[Bug] Preview of CSS selector uses the one saved and not the one entered about freshrss HOT 7 CLOSED

Comments (7)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	$content_selector = Minz_Request::paramString('selector');

	if (!$content_selector) {
	$this->view->fatalError = _t('feedback.sub.feed.selector_preview.selector_empty');
	return;
	}