Giter Club home page Giter Club logo

Comments (7)

yisar avatar yisar commented on May 13, 2024

啊……这个 effects 的 bug 我修了啊 emmm
currentInstance 是 null 的原因是 requestIdleCallback 的调度问题,这个暂时还没办法

正在研究新的调度方案,进度缓慢

from fre.

07akioni avatar 07akioni commented on May 13, 2024

还没把 Fiber 大概搞明白,所以具体逻辑还没搞得很清楚。但我看如果不调用 updateHOOKComponent 的话 currentInstance 就应该一直是 null 吧?这和 requestIdleCallback 关系在哪里呢?

from fre.

yisar avatar yisar commented on May 13, 2024

这和 requestIdleCallback 关系在哪里呢?

因为默认是先调用的 rIC,然后又没有一个好的优先级调度,所以只有在更新的时候才能拿到被更新的 fiber

真正的调度是,默认先执行高优先级的任务,rAF,然后有剩余时间,再执行 rIC

currentInstance 如果是 null,那应该到下一帧的任务里取

现在的 fre 全都是低优先级,没有优先级的调度,其实也失去了异步的意义

待我研究个新的调度器

from fre.

07akioni avatar 07akioni commented on May 13, 2024

我不太理解的点是代码什么时候会运行到到给 currentInstance 赋值,感觉如果没有 typeHOOK 的元素的话,应该 currentInstance 永远是 null 吧。

function beginWork(wipFiber) {
  // 首次运行的时候 wipFiber.type === ROOT
  if (wipFiber.type == HOOK) {
    // 不会进入这里
    // 但是只有进入这个函数才会更新 currentInstance
    updateHOOKComponent(wipFiber)
  } else {
    // 进入这里
    // 这里面会用到 currentInstance,但是不会被初始化,于是就报错了
    updateHostComponent(wipFiber)
  }
}
function updateHOOKComponent(wipFiber) {
  let instance = wipFiber.base
  ...
  currentInstance = instance
  ...
}

from fre.

yisar avatar yisar commented on May 13, 2024

没错,只有更新 hook 的时候才会更新 currentInstance
host 是普通元素,不需要更新 currentInstance,也用不到 currentInstance
currentInstance 实在 setter 的时候用来绑定 this 的

至于那个报错,我之前修复了,可能没提交代码或者提交了又回滚了……

不要急,这几天会研究新的调度,可以过阵子再来看源码

from fre.

07akioni avatar 07akioni commented on May 13, 2024

好 坐等更新

from fre.

yisar avatar yisar commented on May 13, 2024

重构完了,关掉

from fre.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.