Comments (9)
- please add a
debug
ortrace
log output, this might be something else. -fast-path
will be dropped (it is useless if you use anything newer than XP)/gfx
does only work if the remote has it enabled, so not sure this tells us anything
from freerdp.
@akallabeth with pleasure!
xfreerdp2.log
from freerdp.
@frispete ok, the commit you reference is for 32bit color depth, you´re running 16bit (forced by server, your command line specifies 24).
that is using interleaved_decompress
from freerdp.
@akallabeth FYI, here are logs for requesting 16 and 32 bits color depth attached.
xfreerdp2-16.log
xfreerdp2-32.log
from freerdp.
@frispete they are all 16bpp
;)
your server is forcing this.
anyway, don´t currently have time for this but I´ve added it to the list of backports to do.
from freerdp.
don´t currently have time for this but I´ve added it to the list of backports to do
Sure, no problem, the/gfx
work around is doing fine so far.
After being related to this project since more than a decade, I can only express my heartfelt thanks for your tireless efforts! This project is so outstanding because of you!
from freerdp.
Thanks a bunch for addressing these issues @akallabeth
While updating our freerdp2 package from 2.11.5 to 2.11.6, I noticed, that we still carry a CVE-2023-40574-to-2023-40576.patch, that derived from you. It doesn't apply anymore, but interestingly, some parts do:
$ quilt pu
Applying patch freerdp-CVE-2023-40574-to-2023-40576.patch
patching file libfreerdp/primitives/prim_YUV.c
patching file libfreerdp/codec/include/bitmap.c
Hunk #1 FAILED at 46.
Hunk #2 FAILED at 76.
Hunk #3 FAILED at 134.
Hunk #4 FAILED at 144.
Hunk #5 FAILED at 166.
Hunk #6 FAILED at 176.
Hunk #7 FAILED at 197.
Hunk #8 FAILED at 212.
Hunk #9 FAILED at 232.
Hunk #10 FAILED at 257.
Hunk #11 FAILED at 278.
Hunk #12 FAILED at 343.
Hunk #13 FAILED at 351.
Hunk #14 FAILED at 405.
Hunk #15 FAILED at 416.
15 out of 15 hunks FAILED -- rejects in file libfreerdp/codec/include/bitmap.c
patching file libfreerdp/codec/interleaved.c
Hunk #1 succeeded at 26 (offset 1 line).
Hunk #2 succeeded at 334 with fuzz 2 (offset 198 lines).
Hunk #3 FAILED at 244.
Hunk #4 FAILED at 268.
Hunk #5 FAILED at 292.
3 out of 5 hunks FAILED -- rejects in file libfreerdp/codec/interleaved.c
Patch freerdp-CVE-2023-40574-to-2023-40576.patch does not apply (enforce with -f)
In general, I fully trust you and this project, that those issues are addressed in the best possible way, but what puzzles me is that those CVE numbers are not mentioned in the stable-2.0 git log. Can you briefly share your thoughts on this, or should I open another issue regarding this?
Distributions tend to be relatively touchy about CVE numbers these days... 😉
from freerdp.
@frispete in 2.11.6
we backported the whole interleaved.c
and include/bitmap.c
from 3.5.0 with all patches included. (we did quite a rewrite as there were multiple issues with that decoder)
it solves two things, 1 your bug you reported here, 2. out of bound access just like for 3.5.0
from freerdp.
Yep, I see.
Just saying, that you may want to mention somewhere, that these changes fixes CVE-2023-40574, CVE-2023-40575 and CVE-2023-40576 as well to make those silly vulnerability crap*scanners happy.
from freerdp.
Related Issues (20)
- Some asynchronous updates lost HOT 1
- Glyph cache cannot show any characters in login window HOT 3
- Popup menus and window actions do not work correctly in RemoteApp HOT 2
- FreeRDP Display Issues on Ubuntu 24.04 LTS with Windows 10 VM HOT 4
- Issue with /app Flag in FreeRDP 3.5.1 on Flatpak HOT 4
- wlfreerdp and sdl-freerdp crashing with segfault in plasma6 when connecting to windows11 HOT 6
- How to implement USB device redirection in wfreerdp? HOT 1
- Nightly builds segfaults on Ubuntu 22.04.4 HOT 5
- Card Reader/Writer Redirection as "low-level" USB device is not working HOT 8
- The master branch fails to compile with GCC 14.1 HOT 1
- Wiki Documentation update needed for CLI command options listing HOT 1
- Ubuntu 24.04 - xfreerdp2 works with the /app: option but xfreerdp3 does not HOT 1
- Compilation with jpeg-turbo and GCC14 requires changing in winpr/libwinpr/utils/image.c HOT 1
- TimeZoneIanaAbbrevMap.c requires patching to compile with GCC14 HOT 1
- FreeRDP-2.11.6 fails to compile with GCC-14: incompatible pointer types in unicode.c HOT 2
- Black Screen? HOT 6
- Build fails with trying to link shared lib to static gstreamer lib (fPIC) HOT 1
- 3.5.1 build fails with fPIC linker error HOT 2
- How to start Windows applications form Linux short cut?(Or does FreeRDP have this feature?) HOT 5
- 3.5.1 build fails with fPIC linker error HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from freerdp.