DataType Encoding: xml_importer._get_sdef() wrongly assumes, that the first HasEncoding reference represents the default encoding. about opcua-asyncio HOT 5 OPEN

As we currently only support binary, we could just set it to binary by default.

from opcua-asyncio.

Good point, however since the nodes representing encoding like "Default Binary" are created for each and every data-type individually (for whatever reason..), you still have to search for the individual target node with this browse_name/display_name.
I wonder why OPC UA not simply defines (3) global/static nodes, representing the supported encodings in the core node-set. But, it is what it is..

from opcua-asyncio.

That import is already slow, I am really afraid of what is going to happen if we have to do a second pass...
And yes there are probably many of that kind of assumption in the code, in fact when we started implementing these thigns we did not had access to the spec, we had to reverse engineer things...

from opcua-asyncio.

I just stepped through some code to get a better understanding:
As far as I understand, setting the correct DefaultEncodingId should be located somewhere around the _get_sdef() method.:
Reasoning:
The DefaultEncodingId is already utilized during the first pass:

await load_custom_struct_xml_import(node.RequestedNewNodeId, attrs)
    ..
    ua.register_extension_object(name, sdef.DefaultEncodingId, struct, node_id)

IMHO a lot of things could go wrong in trying to adjust the DefaultEncodingId afterwards..

Since I'm not an expert in this project:
Any straightforward way to already access the additional information of the HasEncoding reference target (refdata.target) while iterating through the refs of the datatype node?

from opcua-asyncio.

For those of you looking for a companion specification where the error occurs:
LADS Workshop Project is a demo project for the new
Laboratory and Analytical Device Standard (LADS) which was released by the OPC Foundation last week.
You find the LADS nodeset at OPCF GitHub.
While porting the LADS Workshop Project to opcua-async I did run into the different issues (plus an additional issue around HasEncoding still to be reported).
The current "update" branch, which supports OPC UA 1.05.02 provided a good starting point.

from opcua-asyncio.