Crashes after upload about simple_http_server HOT 4 CLOSED

I think I figured it out. My browser is set to never give a referal header (because privacy). So, this server was trying to convert an empty string into binary, which doesn't work.

To work around this issue, I changed line 82 (in simple-http-server.py) to:

        f.write((b"<br><a href=\".\">Back</a>").encode('utf-8'))

And that seems to have worked! When you have a hyperlink that points to ., that's a quick and easy way to reload the current page, without needing any POST data. It's basically a relative path to "wherever you already are". The above code also ignores your referal header, so it's not an issue anymore.

Tested with python versions 2.7.18 and 3.8.10

from simple_http_server.

add PR

from simple_http_server.

I will make a PR. But first, I'd like to point out that my above code doesn't seem to work on Python3. I guess *.encode commands don't work well with string that start with an unquoted b. Here are two pieces of code that seem to work better:

Option 1:

    f.write(b"<br><a href=\".\">Back</a>")

Option 2:

    f.write(("<br><a href=\".\">Back</a>").encode('utf-8'))

I have no idea which is better. If someone who knows more about Python than I do could weigh in, that'd be great. Maybe it makes no difference?

from simple_http_server.

Since no one has weighed in, I've decided to make a PR with the shorter one. That seems to work well enough. If you choose to accept the PR, feel free to close this report.

from simple_http_server.