Comments (6)
edwh
commented on July 4, 2024
1
Half an hour is about right. We now cache some data on the browser side
for that length of time. That's a fairly recent change for performance
reasons. You are one of the replies counted.
So I think that one is as expected, though you have sharp eyes to notice
it. Let me know when you have an example of the other - though it's
possible that it is the same thing.
------ Original Message ------
From: "John Veness" ***@***.***>
To: "Freegle/iznik-nuxt" ***@***.***>
Cc: "Edward Hibbert" ***@***.***>; "Comment"
***@***.***>
Sent: 04/03/2022 12:26:39
Subject: Re: [Freegle/iznik-nuxt] Miscounting in "X freeglers replied"
text? (Issue #395)
I can't give any examples of behaviour 1 right now, but an example of
behaviour 2 is in message 87502332. When I first saw the item, it had
been promised and showed 1 freegler had replied. I also replied, but
the count stayed at 1 for a long time (half an hour?), and yes, I had
refreshed several times. It now shows 2 freeglers replied, but that
might be due to someone else replying.
—
Reply to this email directly, view it on GitHub
<#395 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAN26BL5AU7TY3DPY7Z4HTU6H6P7ANCNFSM5P5L3BTQ>.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you commented.Message ID:
***@***.***>
…from iznik-nuxt.
edwh
commented on July 4, 2024
1
I can update the message easily enough. "You and X" is harder, so I'm not likely to do that.
from iznik-nuxt.
edwh
commented on July 4, 2024
Can you give me specific examples of these, please? Then I can check them.
…On 4 March 2022 12:09:38 GMT, John Veness ***@***.***> wrote:
Hi. I'm wondering if there is a problem in recent weeks with the "X freeglers replied" text shown under the description of an item. I have seen two behaviours recently, which I don't remember seeing before, let's say, this calendar year.
1, I have seen quite a few items that say they are promised to someone, but say "No replies yet". I understand that it's possible to promise an item to someone even if they haven't replied specifically to that item (i.e. if they have replied to another item from the same member), but it seems strange that I've seen it so often recently.
2, I replied to an item with already had one reply, and after I sent my reply, the reply count did not increase. I'm sure the reply count did use to increase when I replied to an item. I have only seen this once, and it was when I had replied to an item which had already been promised to someone else, if that is relevant.
Thanks!
--
Reply to this email directly or view it on GitHub:
#395
You are receiving this because you are subscribed to this thread.
Message ID: ***@***.***>
from iznik-nuxt.
JohnVeness
commented on July 4, 2024
I can't give any examples of behaviour 1 right now, but an example of behaviour 2 is in message 87502332. When I first saw the item, it had been promised and showed 1 freegler had replied. I also replied, but the count stayed at 1 for a long time (half an hour?), and yes, I had refreshed several times. It now shows 2 freeglers replied, but that might be due to someone else replying.
from iznik-nuxt.
JohnVeness
commented on July 4, 2024
Ah, OK, I guess it must be just the caching, and maybe that's the cause of the other behaviour I've seen too.
I'm not sure about sharp eyes, but it is particularly noticeable when the number doesn't increase (or even worse, if it still says "No replies yet") after you've replied yourself. It makes one doubt whether the reply has properly worked, which is offputting (and requires double-checking in Chat and so on). I don't know if it's possible for you to detect that particular case and update the cached number immediately in that situation? It's not so important to have an up-to-date count of how many other people have replied, but it is useful to be reassured that your own reply has gone through!
from iznik-nuxt.
JohnVeness
commented on July 4, 2024
In fact (and maybe this should be a separate issue), it would be great if the text could say something like "You and X other freeglers have replied" or "Y freeglers replied (including you)" or similar. I.e. to specifically note that you have replied.
Yes, one would expect one would remember which items one had replied to, but it seems to me that the extra reassurance wouldn't hurt!
from iznik-nuxt.
Related Issues (20)
- Suggestion: "does this look ok?" quiz should show all photos HOT 1
- Editing issue - postcode is always replaced with the poster's own regardless of what was in the post HOT 4
- Need to be able to promise items to correspondents possibly not linked to item HOT 4
- Displays wrong photo HOT 6
- Encoding error with adverts HOT 1
- Inform user if they have contacted another user previously HOT 4
- Make chats per-item, not per-member HOT 1
- "This item has already been promised to someone" text when that someone is you HOT 1
- "Connected before" shows even if you've only opened (but never sent or received) a chat with someone HOT 1
- Show text of an item when viewing a chat HOT 3
- Email copies of chat messages remove exclamation marks HOT 1
- Portrait photos are cropped on landscape screens HOT 2
- Zoomer doesn't show all of the image HOT 9
- Wrong tooltip when hover over group name in a profile block HOT 1
- Item promised text bubble HOT 3
- Diagonal "PROMISED" banner not clickable HOT 1
- "Connected before" text disappears if you view user profile HOT 3
- Email copies of chat messages don't get sent sometimes HOT 1
- "What the enter key does" setting sometimes reverts HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from iznik-nuxt.