Giter Club home page Giter Club logo

Comments (8)

ojongerius avatar ojongerius commented on June 3, 2024

I'm all for this.

I do see merit in having consistency in regards to a full stop, the only thing I care about is consistency. Happy to keep enforcing full stops?

from open-api.

Bouncey avatar Bouncey commented on June 3, 2024

Are we enforcing full stops? Haven't tripped that rule yet

from open-api.

ojongerius avatar ojongerius commented on June 3, 2024

I'm guilty of having tripped that plenty of times, an old habit. Appears commitlint/config-conventional, which we extend, enforces subject-full-stop.

from open-api.

Bouncey avatar Bouncey commented on June 3, 2024

So, are we saying

  • full stop - yes
    or
  • full stop - no

??

from open-api.

ojongerius avatar ojongerius commented on June 3, 2024

Let's keep the default of "full stop - no".

from open-api.

user512 avatar user512 commented on June 3, 2024

May I work on this? My assumption to config the subject-case rule. (http://marionebl.github.io/commitlint/#/reference-rules?id=subject-case)

from open-api.

ojongerius avatar ojongerius commented on June 3, 2024

All yours @user512 !

from open-api.

user512 avatar user512 commented on June 3, 2024

@Bouncey I tested the PR with your example commit message and returns no error/ warning.

from open-api.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.