Giter Club home page Giter Club logo

Comments (13)

FrederickHuangLin avatar FrederickHuangLin commented on June 15, 2024 2

Hi @kazubado33,

I am pleased to share with you that the major update for ANCOMBC package has been completed. Here are some highlighted new features:

  • Add ancombc2 function, which supports pairwise test (with mdFDR control) and trend test for both cross-sectional and repeated measurements data
  • Add sensitivity analysis for pseudo-count addition
  • Fully support the (Tree)SummarizedExperiment class
  • A more user-friendly output layout

I just pushed the changes to the Bioconductor branches. It might take a few business days for the package to become available (but the devel version is ready here!).

Best,
Huang

from ancombc.

kazubado33 avatar kazubado33 commented on June 15, 2024 1

Thanks for the great discussion.

I am updating the package now and waiting for more unit testings. There is gonna be a major update for ANCOMBC package in a month or two to reflect this new feature (in addition to trend test and repeated measures).

Has there been a major update to incorporate a mixed-directional FDR (mdFDR) model yet at this time?

Thank you in advance for your help.
kazubado33

from ancombc.

FrederickHuangLin avatar FrederickHuangLin commented on June 15, 2024 1

Hi @marwa38,

I am not the developer or maintainer of the bioconda package, but it seems that it is up-to-date (v2.0.1).

Best,
Huang

from ancombc.

andrebolerbarros avatar andrebolerbarros commented on June 15, 2024

This is an interesting question, because I would imagine you are interested in post-hoc, pairwise comparisons right? Well, either you subset pairs & perform the ancombc function or some post-hoc approach needs to be developed (like emmeans for example?).

Honestly, the subsetting approach looks the pratical one in the short term but, I have some reservations regarding if it would be correct or not.

from ancombc.

Anaherasm avatar Anaherasm commented on June 15, 2024

Thank you your response. Exactly, that would be what I want to do. I performed the ANCOMBC analysis with global=T, since I understood that that would tell me wether there is any difference between 2 or more groups. But I wanted to know where were the differences exactly. I'll do what you propose, to perform the ANCOMBC between each pair (even though I am not sure if its the most correct one)

from ancombc.

andrebolerbarros avatar andrebolerbarros commented on June 15, 2024

Yeah, in statistical terms, it might not be the most correct one indeed. One solution would be to double-correct the p-values for comparisons (for example, holm for multiple comparison & FDR for multiple hypothesis testing) but, that also sounds like a tad overkill (although, if you get p-values with this approach, you might be on the safe side indeed). Another solution might be either use a stringent alpha criteria (let's say 0.01) or use a Fold Change threshold as filtering criteria as well (you might filter small changes that can be attributed to noise).

from ancombc.

FrederickHuangLin avatar FrederickHuangLin commented on June 15, 2024

Thanks for your question, @Anaherasm, and thanks for your answer, @andrebolerbarros!

I agree with @andrebolerbarros that if you are interested in post-hoc, pairwise comparisons, you can perform ANCOMBC between each pair at this moment.

I understand it is not satisfying as it could inflate the FDR but double-correcting the p-values seems too conservative. We have the updated methodology ready and decided to implement a mixed-directional FDR (mdFDR) control for such pairwise comparison case. I am updating the package now and waiting for more unit testings. There is gonna be a major update for ANCOMBC package in a month or two to reflect this new feature (in addition to trend test and repeated measures).

Best,
Huang

from ancombc.

andrebolerbarros avatar andrebolerbarros commented on June 15, 2024

Thanks @FrederickHuangLin! And very good news indeed!

Considering you are performing major updates to the package, have you considered to organize the final results more in a user-friendly table, a similar table to the one DESeq2 (https://bioconductor.org/packages/release/bioc/html/DESeq2.html) produces, for example? It would summarize the results in a more consise fashion and would make the end-user life easier, that would not need to merge several tables.

If you prefer, I can open a suggestion/issue with this contribution.

Cheers,

André

from ancombc.

FrederickHuangLin avatar FrederickHuangLin commented on June 15, 2024

That is a great idea @andrebolerbarros!

Feel free to open a suggestion/issue regarding it.

Best,
Huang

from ancombc.

Anaherasm avatar Anaherasm commented on June 15, 2024

Thank you to both of you for your kind answers. I will do as you say. However, I then have a doubt regarding the global option for analysis: i have thought that it means that, when you have more than one option, if its significant, it means that there is at least one difference between groups of comparions, even if it doesn't especify which groups are different. Am I correct, and then it would be useful for me, or I have understood it completely wrong???

from ancombc.

FrederickHuangLin avatar FrederickHuangLin commented on June 15, 2024

Hi @Anaherasm,

if its significant, it means that there is at least one difference between groups of comparions, even if it doesn't especify which groups are different

That is completely correct.

Best,
Huang

from ancombc.

Anaherasm avatar Anaherasm commented on June 15, 2024

Perfect, thank you for your answer

from ancombc.

marwa38 avatar marwa38 commented on June 15, 2024

Hi @FrederickHuangLin
Many thanks for sharing the latest update, could you please let me know if this conda https://anaconda.org/bioconda/bioconductor-ancombc is supported and developed by you and had the recent features?
Thank you
Marwa

from ancombc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.