Giter Club home page Giter Club logo

Comments (4)

telegraphic avatar telegraphic commented on August 16, 2024 1

Shoutout to fruitbat, which probably does what you want 🦇. It lets you choose a method, cosmology and then will convert a DM to redshift:
https://fruitbat.readthedocs.io/en/latest/user_guide/method_and_cosmology.html

(fruitbat uses pygedm under the hood for Galactic DM calculations)

Would it be fair then to say this tool is primarily (solely?) intended for pulsars given the constraints of today's electron density models, or are there any utilities for FRBs that I'm overlooking?

Well, NE2001/YMW16 is cited in pretty much every FRB detection paper, so I'd say not fair! To estimate FRB distances we still need to know the DM contribution of the Milky way. But it is true that pygedm only deals with the Milky Way, so is only part of the puzzle, and that it's useful for pulsars too.

from pygedm.

telegraphic avatar telegraphic commented on August 16, 2024

Hi @0xCoto -- the NE2001 and YMW16 models are Galactic only, and do not include the halo, so what you're seeing there is that the code has reached the edge of the model and is not integrating further.

If you use the inverse and plug in 25 kpc, you see that the DM contribution along those lines of sight is:

In [6]: pygedm.dist_to_dm(356.64, -20.02, 25000*u.pc)
Out[6]: (<Quantity 75.90722656 pc / cm3>, <Quantity 6.83889903e-06 s>)

In [7]: pygedm.dist_to_dm(60.07, -38.35, 25000.0)
Out[7]: (<Quantity 32.47999573 pc / cm3>, <Quantity 2.64335114e-07 s>)

In [8]: pygedm.dist_to_dm(274.72, -33.3, 25000.0)
Out[8]: (<Quantity 54.87789917 pc / cm3>, <Quantity 1.88222407e-06 s>)

So I believe the code is behaving, but perhaps it would make sense to raise a warning that you're integrating to the edge of the model?


This is definitely a typo! Thanks for picking this up -- the order (l,b) is correct so should just be the docstring.

from pygedm.

0xCoto avatar 0xCoto commented on August 16, 2024

Hi Danny, many thanks for the quick response!

I see, this actually makes sense... Although I was already 'subconsciously' aware our extragalactic models were limited, I suppose the fact that this tool is under FRBs/ on GitHub tricked me to forget this for a second! :)

Would it be fair then to say this tool is primarily (solely?) intended for pulsars given the constraints of today's electron density models, or are there any utilities for FRBs that I'm overlooking?

from pygedm.

0xCoto avatar 0xCoto commented on August 16, 2024

Ok, redshift is actually quite useful indeed!

Nice to hear fruitbat makes use of pygedm in the background; indeed galactic DM contribution is super important. Thanks for the suggestion, will definitely look into that!

from pygedm.

Related Issues (17)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.