Comments (6)
ankush
commented on June 18, 2024
User is supposed to be bool flag, cache is either user specific or not. Rest of rediswrapper works like this.
Passing actual string is only useful when you want to set cache for specific known user. We should just get rid of this functionality TBH 🥴
from frappe.
casesolved-co-uk
commented on June 18, 2024
Every call that I looked at used user as a value not a bool
from frappe.
ankush
commented on June 18, 2024
It's not used anywhere? Just added for sake of completeness.
from frappe.
casesolved-co-uk
commented on June 18, 2024
I meant underneath: frappe.cache.get/set_value
from frappe.
ankush
commented on June 18, 2024
frappe/frappe/utils/redis_wrapper.py
Lines 44 to 46 in 0f48cbb
from frappe.
casesolved-co-uk
commented on June 18, 2024
Fair enough but I think this is not obvious and dangerous. The user parameter should be validated in the decorator as a bool only.
It even has a str type option:
frappe/frappe/utils/caching.py
Line 135 in 5d51320
I was hoping to use it on this:
#26024
from frappe.
Related Issues (20)
- OpenTelemetry Log, Metric, Trace Integration
- Add option to set default report view for doctype HOT 3
- EMail status tracking not working HOT 6
- Virtual Field Listview data
- Date picker gets translated, leading to non-sensical results HOT 1
- SessionBootFailed: changelog feed error. HOT 1
- local.conf set with get_site_config() but nothing is returned
- email tracking should not check frappe.conf.use_ssl
- `local.primary_db` and `local.replica_db` both references the Replica DB connection after calling `frappe.connect_replica()`
- In List View, sort `List Filters` by filter name
- Accounting Dimension on Journal Entry is not Fetched from Invoices/Payments when Invoice Reconciled against Credit Note using Payment Reconciliation
- Link Field removes extra spaces between words in lookup DocType HOT 3
- Cannot delete States in v15 workflow builder
- valuesOverPoints in charts not working
- Notification context overwritten
- Option to Replace Files from Frontend
- valuesOverPoints in Workspace charts not working .. as conflict with codex-editor class
- Ctrl + S not working when bottom Search box appears
- Translations: Babel Python extractor not extracting translations from comments
- Event all does not exist
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from frappe.