Giter Club home page Giter Club logo

Comments (3)

Matthbo avatar Matthbo commented on August 14, 2024

On default, when show inheritance is enabled, it merges all the attributes etc. into the element. When you then hide the inheritance it will show the parent classes with their own attributes etc.
This is also how it was done in the old version of the frankdoc except for that the button was not only labelled incorrectly but also improperly copied and changed codewise.
This has been corrected in the current version meaning that the behaviour isn't changed at all

from frank-doc.

Laurens-makel avatar Laurens-makel commented on August 14, 2024

I am not implying any behaviour has been changed :)

Isn't it weird that when I press 'Hide Inheritance' it actually shows me all inherited attributes and when I press 'Show Inheritance' it actually hides all inherited attributes?

from frank-doc.

Matthbo avatar Matthbo commented on August 14, 2024

It shouldn't hide it but show it merged into the given element, but I did find a bug that makes it not show the inherited attributes at all because of an error caused by an angular pipe which breaks for some reason after flipping the show/hide inheritance button.
This likely happened because of a big refactor to clean up/improve the old code

Intended behaviour:
image

After switching show inheritance -> hide -> show:
image

Production stacktrace:

ERROR TypeError: Cannot read properties of undefined (reading 'getDisplayName')
    at transformLink (main.81fe4c4b999354ea.js:1:274063)
    at String.replace (<anonymous>)
    at e.transform (main.81fe4c4b999354ea.js:1:273855)
    at Ay (main.81fe4c4b999354ea.js:1:84537)
    at Fy (main.81fe4c4b999354ea.js:1:274687)
    at dk (main.81fe4c4b999354ea.js:1:274731)
    at Sg (main.81fe4c4b999354ea.js:1:56961)
    at Vs (main.81fe4c4b999354ea.js:1:55744)
    at c0 (main.81fe4c4b999354ea.js:1:56163)
    at Vs (main.81fe4c4b999354ea.js:1:56189)

from frank-doc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.