Suggestion: Replace macro SOPWITH1_TUNE with a menu option about sdl-sopwith HOT 4 CLOSED

I haven't done such work so far. What I probably did earlier in 2023 was not much more than undefining SOPWITH1_TUNE and inspecting the code.

If you indeed add the feature for user maps, question is if it'll be specific to the maps themselves or also hold to the menu before starting a proper game, say if you add the option of selecting a user map from the menu. But that's probably a topic for discussion outside of this issue, if at all.

from sdl-sopwith.

I've considered it in the past but I don't think it would be worth the additional clutter on the options menu. I'm planning to add the ability to override the tune in custom map files so that would be an option for people who really want to hear it instead of the Sopwith 2 tune.

from sdl-sopwith.

ok, I've actually thought about giving this a try again and implementing it before your comment. Either with the toggle not immediately having an immediate effect while tune is already playing, or the opposite (by stopping tune being played and starting the other one if actual game was not started). I've also thought it should be consistent with the presence of existing menu toggles, like "Solid ground". Given your response, I can leave this by the side.

from sdl-sopwith.

from sdl-sopwith.