Build failed with -DSOCKPP_BUILD_TESTS=ON about sockpp HOT 7 CLOSED

This was fixed by PR #84, and merged into the 'develop' branch, but not yet promoted to 'master' nor released. Development is still a bit unstable.

But with this fix, the build system will determine if Catch2 is v2.x or v3.x and include the proper header file.

Unfortunately, I have a few other open-source projects queued for release before I get to this one, so it will likely be a few months before this is released. In the meantime, if you really need to run the tests, you can build against v2.x or perhaps try to cherry-pick the PR into your local build.

from sockpp.

If I understand this patch correctly, in case of catch2 v3 we need just to replace #include "catch2/catch.hpp" by #include "catch2/catch_all.hpp" in all test/unit/*.cpp files?

In such case I would just add such patches into the ports tree waiting for the new release of sockpp. We don't need a support for building with <v3 in ports as the version of catch2 is fixed by the version of catch2 port. So, the patch can be relatively simple.

from sockpp.

Yes. The patch (PR) just uses CMake to discover if v2.x or >=v3.x is installed and sets a flag for which of those two headers to include in all the test source files.

The tests themselves just use a minimal set of features that are compatible with either version.

from sockpp.

I assume this is resolved? If not, feel free to re-open.

from sockpp.

It seems that the patch is not included in the last release. Please, drop some lines here when you release a version with this patch included, so we remove the patch from port.

from sockpp.

I just added a few small bug fixes to the v0.8.x line, holding off on new features until v0.9 which should be out soon. (I would consider adding support for Catch v3 as a new "feature").

But maybe the PR would cherry pick cleanly. I'll give it a try, and if it works, I'll push it out.

from sockpp.

Done.

v0.8.3 supports Catch2 versions 2.x and 3.x

from sockpp.