Improving Layout For App about foxmagiskmodulemanager HOT 20 CLOSED

I don't think it fits to the right because it would cover the toggle, delete and link buttons.
Would be better to just keep it in the top bar like Play Store or YouTube.

from foxmagiskmodulemanager.

Telegram -> https://t.me/Fox2Code_Chat
I will definitely try to improve the app UI.

from foxmagiskmodulemanager.

@nikolowry I tried to fix it in c3d8213 but no guarantee it will fix the issue.

from foxmagiskmodulemanager.

While I'm a long time java developer and have experience with root, I'm not really good at making good UIs.

While I'm improving, this will probably not happen any time soon.

Same problem with the #34 request.

from foxmagiskmodulemanager.

would like to suggest some more things related to layout: make the Download/Install button and Info button, bigger and separate them out further.

It has happened with me a few times, I wanted to see the info but pressed the other button by mistake and boom, the module was installed.

edit: I don't know if I should make a new issue for this or writing it here was okay, if a new issue is to be made then please inform me, I'll create a new one.

from foxmagiskmodulemanager.

Yeah I definitely need help.

from foxmagiskmodulemanager.

There is no fix, there is only improvement. Nothing is perfect, but everything can be better.
Especially when talking about user interface because everyone have their personal preferences.

from foxmagiskmodulemanager.

If someone want to do the changes, why not, but I'm not doing it.
I already struggle with the UI enough.

from foxmagiskmodulemanager.

Hey, I can offer some help in making the UI a bit more material design, if you want I can also move the UI to jetpack compose & kotlin, lmk if you are interested

from foxmagiskmodulemanager.

You should also add padding to the recyclerview items, and change the search icon to a solid color fab.

I will add a pull request when I have some time

from foxmagiskmodulemanager.

@Electric1447 the was already change with RC-1.
Please join telegram for community feedback:
https://t.me/Fox2Code_Chat

from foxmagiskmodulemanager.

I have fixed the darkmode in #107

from foxmagiskmodulemanager.

Ever since UI updates started to be pushed, I've been encountering an issue with the app bar (see screen recording): https://neeks.me/cloud/index.php/s/GxDdNgqCHntf9gy

Device: Pixel 5
OS: ProtonAOSP 12.3.1 (12L)

from foxmagiskmodulemanager.

Ever since UI updates started to be pushed, I've been encountering an issue with the app bar (see screen recording): https://neeks.me/cloud/index.php/s/GxDdNgqCHntf9gy

Device: Pixel 5 OS: ProtonAOSP 12.3.1 (12L)

Looks like device depend. I facing no issues on Pixel Experience rom.

from foxmagiskmodulemanager.

@nikolowry I tried to fix it in c3d8213 but no guarantee it will fix the issue.

Just updated to https://github.com/Fox2Code/FoxMagiskModuleManager/releases/tag/0.4.4, but unfortunately the issue was not fixed. Thanks for the speedy attempt though, feel free to @ me if you want me to check again

from foxmagiskmodulemanager.

I consider this done with the monet update. @Fox2Code feel free to reopen if you feel otherwise.

from foxmagiskmodulemanager.

@Fox2Code I was able to pinpoint my issue, it's due to an atypical device configuration. I prefer to set my Pixel 5 "Font-Size" to "Small" and "Display" to "Default". Attaching a video demonstrate: https://neeks.me/cloud/index.php/s/z2sxTKXAfWrb5Zi

I don't usually target Android in my daily development life, but maybe Layout Inspector and Layout Validaton could help: https://developer.android.com/studio/debug/layout-inspector

from foxmagiskmodulemanager.

Making layout adapt to every devices take time, I just put assumptions on layout to not take too long to release the next update, I prefer making releases faster, even if it contains some bugs.

from foxmagiskmodulemanager.

@Fox2Code there are thousands of different device configurations, so I was not suggesting to target my specific configuration -- but rather figure out the "right way" to calculate UI dimensions:

• https://blog.prototypr.io/designing-for-multiple-screen-densities-on-android-5fba8afe7ead
• https://medium.com/programming-lite/best-practices-for-supporting-android-application-in-multiple-screen-a685afa83493
• https://blog.mindorks.com/understanding-density-independent-pixel-sp-dp-dip-in-android

from foxmagiskmodulemanager.

Happy to report the DPI issues I was experiencing has been resolved in one of the latest releases. Thanks!

from foxmagiskmodulemanager.