Giter Club home page Giter Club logo

Comments (9)

OliverNChalk avatar OliverNChalk commented on May 22, 2024 4

Just wanted to sanity check the forge snapshot --diff feature. Here is what I currently use, it's:

forge snapshot && git diff --word-diff .gas-snapshot
image

Here's what forge snapshot --diff produces:
image

It looks like the gas diff per case is computed as: case_change / total_gas_previous which seems off, I would have expected it to be: case_change / case_previous.

I would also argue that showing before, after, delta is helpful but that may just be personal preference

from foundry.

transmissions11 avatar transmissions11 commented on May 22, 2024 1

@transmissions11 might be worth adding some checkboxes and editing it to link out to PRs once implemented. Mean and median gas on fuzz tests was added in #236

good idea, done. also added flamegraphs

from foundry.

lucas-manuel avatar lucas-manuel commented on May 22, 2024

Whats left on this? Table formatting?

from foundry.

wilsoncusack avatar wilsoncusack commented on May 22, 2024

I don't think any of this is done except gas for fuzzed tests?

from foundry.

mds1 avatar mds1 commented on May 22, 2024

Breakdown of not only gas usage of tests but gas usage of functions the tests call like hardhat-gas-reporter

This one is arguably implemented as you can see gas usage by function in traces, as in #192 (comment), but a report/snapshots showing this would be nice to have

Also I think flamegraphs should be added to this list, below is Tenderly's for reference

image

@transmissions11 might be worth adding some checkboxes and editing it to link out to PRs once implemented. Mean and median gas on fuzz tests was added in #236

from foundry.

onbjerg avatar onbjerg commented on May 22, 2024

Backref #1795

from foundry.

wdv4758h avatar wdv4758h commented on May 22, 2024

Is there a place to show Deployment Cost diff right now?
Not sure if this is in the snapshot scope, but I will be happy if it's in snapshot diff.
I've been working to cut the contract size, tracking the size in snapshot helps.

from foundry.

lucas-manuel avatar lucas-manuel commented on May 22, 2024

Close-able? @mds1

from foundry.

mds1 avatar mds1 commented on May 22, 2024

Closing in favor of #2056

from foundry.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.