Comments (11)
Sorry about that... It's a bug that happens for views with more than one root node.
It should be fixed in the next few days, this commit in #32 addresses that. Feel free to try that branch if you want in the meantime...
I'll close this issue when I release it.
from inky-rb.
Should be completely addressed with 1.3.7.0. Let us know if that's not the case! Thanks for reporting this.
from inky-rb.
from inky-rb.
So what I found tonight is that while this appeared to work properly in my local dev environment, it's not working for me on my staging environment on Heroku...
from inky-rb.
@sdhull Probably an issue with deploying?
From the Ruby console, check the result of Inky::Rails::VERSION
from inky-rb.
Yeah, I thought it was maybe something like that too, however from heroku console:
irb(main):008:0> Inky::Rails::VERSION
=> "1.3.7.0"
When I try to send emails from the console, inky templates don't send at all. When I inspect the mail object returned, the body is nil
.
irb(main):005:0> mail.html_part
=> nil
But emails with just html templates send fine (I haven't converted existing templates to inky).
from inky-rb.
Mmm, so it's not the same bug (the <style>
used to render), right?
Ideally open a new issue, but I won't be able to check it out let alone fix it unless you manage to dig a bit further. The gem is quite small, and there's a rails test so maybe you can figure out what's causing the issue?
from inky-rb.
Figured it out. Submitted a PR to fix it.
from inky-rb.
Yeah, I thought it was maybe something like that too, however from heroku
console:
irb(main):008:0> Inky::Rails::VERSION
=> "1.3.7.0"
When I try to send emails from the console, inky templates don't send at
all. When I inspect the mail object returned, the body is nil
.
irb(main):005:0> mail.html_part
=> nil
But emails with just html templates send fine (I haven't converted existing
templates to inky). I guess maybe the gem isn't ready for primetime and I
should just convert my views back to html.erb :(
from inky-rb.
Probably an issue with deploying?
From the Ruby console, check Inky::Rails::VERSION
On Fri, Oct 21, 2016 at 3:36 AM, Steve [email protected] wrote:
So what I found tonight is that while this appeared to work properly in my
local dev environment, it's not working for me on my staging environment on
Heroku...—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#35 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AACD6nw8CMCl6u-O3QrhZtuEX3zJGGleks5q2GuZgaJpZM4KS2_N
.
from inky-rb.
lol sorry I sent that last Friday while Dyn was under attack. When Dyn had recovered I just came to Github and left the comment. Apparently the DDoS attack delayed the processing of this email. You can ignore this, sorry.
from inky-rb.
Related Issues (20)
- Deprecation warning for Rails 6.1
- Webpacker support? HOT 3
- Status of inky-rb? HOT 1
- Missing support for <h-line> HOT 2
- Rails 7 support? HOT 4
- Using <columns> as rails partials mess with column order classes.
- Precompilation error HOT 1
- Anybody attempted inky precompile?
- Change `components` settings? HOT 2
- Special Char Strip HOT 1
- generator not available HOT 3
- HTML encoding is being forced to US-ASCII, causing transfer encoding issues down the line HOT 5
- Add wiki or section in README for syntax highlighting HOT 1
- Plain text body
- Data Table HOT 1
- Fix character escaping (')
- Why not generate .inky layouts? HOT 1
- How do I access the inky parser HOT 1
- custom padding added to column is incorrectly manipulated by foundation HOT 1
- <raw> tags not working, and neither is components config
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from inky-rb.